Ubuntu
ubuntu-themes package

Appearance regression for "inline-toolbar" styled GtkToolbar with more than 2 packed GtkToolButtonItems

Asked by Andrew Chadwick

Xenial's Amibience and Radiance themes make GtkToolbar widgets with 3 or more packed GtkToolButtonItems packed into them look strange if the toolbar has the "inline-toolbar" style (GTK_STYLE_CLASS_INLINE_TOOLBAR). There are screenshots available at this downstream bug: https://github.com/mypaint/mypaint/issues/684

Clusters of widgets like these are seen in the MyPaint layers panel (hi, developer here), and can be observed with gtk3-demo (CSS Theming → Style Classes). They're a common way of making small groups of list tools available.

The whole point of inline-toolbar as I understand it is to make toolbars of 2 *or more* tool items join up nicely. Xenial has rearranged a lot of these toolbars into pairs, and I respect that for usability reasons. However this regression seems like a bug to me. Not all groups of related actions can be clustered into pairs! I *don't* think we're abusing GTK, since this pattern looks just fine in Debian GNOME under Adwaita from GTK+ 3.20.4 (gnome-themes-standard 3.20).

Please can you confirm whether you consider this a bug, and if so turn it into one?

Question information

Language:
English Edit question
Status:
Expired
For:
Ubuntu ubuntu-themes Edit question
Assignee:
No assignee Edit question
Last query:
Last reply:
Revision history for this message
Andrew Chadwick (achadwick) said : 		#1

Affects Xenial (16.04LTS) light-themes 14.04+16.04.20160415-0ubuntu1.
Does not affect Wily (15.10) light-themes 14.04+15.10.20151001-0ubuntu1.

Revision history for this message
Loentar (loentar) said : 		#2

Reproducible with this code:

```
#!/usr/bin/python3

from gi.repository import Gtk
win = Gtk.Window()
toolbar = Gtk.Toolbar()
toolbar.set_property("icon_size",1)
context = toolbar.get_style_context()
context.add_class(Gtk.STYLE_CLASS_INLINE_TOOLBAR)
context.add_class("linked")
toolbar.set_show_arrow(False)

toolitem = Gtk.ToolButton()
toolitem.set_property("icon_name","list-add-symbolic")
toolitem2 = Gtk.ToolButton()
toolitem2.set_property("icon_name","list-add-symbolic")
toolitem3 = Gtk.ToolButton()
toolitem3.set_property("icon_name","list-add-symbolic")

toolbar.insert(toolitem, -1)
toolbar.insert(toolitem2, -1)
toolbar.insert(toolitem3, -1)
win.add(toolbar)
win.connect("delete-event", Gtk.main_quit)
win.show_all()
Gtk.main()
```

When started on Ubuntu 15.10 (as well as on prior versions) it looks OK, when started on Ubuntu 16.04 the toolbar button appearance is broken: https://cloud.githubusercontent.com/assets/4038431/15448796/93ac2b0a-1f74-11e6-84f2-3caaba555f7b.png.

Revision history for this message
Launchpad Janitor (janitor) said : 		#3

This question was expired because it remained in the 'Open' state without activity for the last 15 days.

Revision history for this message
Andrew Chadwick (achadwick) said : 		#4

Since no theme maintainer has responded here, I've opened a bug about it, and this is the approach I'll be taking in future on Launchpad.

https://bugs.launchpad.net/ubuntu/+source/light-themes/+bug/1589494

Revision history for this message
Amr Ibrahim (amribrahim1987) said : 		#5

The light-themes source was removed after Precise. It was replaced with the ubuntu-themes source in Trusty and above. You reported the bug against the light-themes source, which doesn't exist in Xenial. The correct source is ubuntu-themes.