Comment 27 for bug 1373928

Revision history for this message
In , Lionel Elie Mamane (lionel-mamane) wrote :

(In reply to comment #23)
> Sorry, I was probably not clear enough in my first comment. :-/
>
> (In reply to comment #22)
> > So we should change the dlopen() mechanism in the mergedlibs case
>
> Ideally we would just kill this dlopen.

That's a good plan for master, and WiP is at https://gerrit.libreoffice.org/11737

*But* I wouldn't do that in the stable branch... Additionally to timing issues (that is, when will the full "kill the dlopen()" be done?), it is a rather bigger change, and instead of making many changes everywhere, I'd rather the dlopen mechanism (that is, the whole svx/dbtoolsclient) just didn't do the dlopen(); that's *one* change in *one* place, "neutering" the mechanism instead of killing it (that is, essentally making it a no-op instead of changing every place that calls it to not call it).

>> Is there an "#ifdef" we can do to detect mergedlibs case?

> git grep CUI_DLL_NAME vcl/ shows

> -DCUI_DLL_NAME=\"$(call gb_Library_get_runtime_filename,$(call
> gb_Library__get_name,cui))\" \

> in makefile, and you can then use in source CUI_DLL_NAME instead of just
> "cui" without any #ifdefs
> It expands to the exact platform specific name, so no need for SVLIBRARY
> then.

You mean "$(call gb_Library__get_name,cui)" will expand to "mergedlib" (or something like that) in the --enable-mergedlib case?