Comment on attachment 726580 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name()
Review of attachment 726580: -----------------------------------------------------------------
::: i/accessible/src/atk/AccessibleWrap.cpp @@ +147,5 @@ > #endif > > G_BEGIN_DECLS > + > +static void AtkObjectSetName(AtkObject *aAtkObj, const gchar *name);
nit: type* name (here and below)
@@ +647,4 @@ > > NS_ConvertUTF8toUTF16 objName(aAtkObj->name); > if (!uniName.Equals(objName)) > + AtkObjectSetName(aAtkObj, NS_ConvertUTF16toUTF8(uniName).get());
nit: you can change the code to use one conversion
@@ +654,5 @@ > > +static void > +AtkObjectSetName(AtkObject *aAtkObj, const gchar *name) > +{ > + /* This function duplicates the functionality of atk_object_set_name(),
nit: We use '//' comment style in function body
Comment on attachment 726580 set_name( ) which mimics the behavior without calling atk_object_ get_name( )
Implement a replacement of atk_object_
Review of attachment 726580: ------- ------- ------- ------- ------- ------- ------- ------- --
-------
::: i/accessible/ src/atk/ AccessibleWrap. cpp e(AtkObject *aAtkObj, const gchar *name);
@@ +147,5 @@
> #endif
>
> G_BEGIN_DECLS
> +
> +static void AtkObjectSetNam
nit: type* name (here and below)
@@ +647,4 @@ oUTF16 objName( aAtkObj- >name); Equals( objName) ) e(aAtkObj, NS_ConvertUTF16 toUTF8( uniName) .get()) ;
>
> NS_ConvertUTF8t
> if (!uniName.
> + AtkObjectSetNam
nit: you can change the code to use one conversion
@@ +654,5 @@ me(AtkObject *aAtkObj, const gchar *name) set_name( ),
>
> +static void
> +AtkObjectSetNa
> +{
> + /* This function duplicates the functionality of atk_object_
nit: We use '//' comment style in function body