Release Upgrader

Odd string

Asked by AO on 2019-04-09

Hi,

In Disco, for ubuntu-release-upgrader package, there is currently an odd string:
%sing snap %s

What does the "%sing" part stand for?

Best,

AO

Question information

Language:
English Edit question
Status:
Answered
For:
Release Upgrader Edit question
Assignee:
No assignee Edit question
Last query:
2019-04-09
Last reply:
2019-06-18

This question was reopened

Manfred Hampl (m-hampl) said : #1

"%s" is a placeholder that is filled with a string parameter, and "ing" is constant text.

Digging into the source https://git.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/tree/DistUpgrade/DistUpgradeQuirks.py#n459 (not sure whether it is the right version), it seems to be another example of bad tricks that make translations impossible.

As far as I can see there are two branches, and depending on the status of the snap, it is either installing or refreshing that snap.
The value of "command" is either "install" or "refresh", and the string %sing results either in "installing" or in "refreshing".

With the way that this was done, I do not see any possibility that the words "install" and "refresh" could be translated to a different language.

The only reasonable solution that I can suggest is a split into two messages, e.g.
…
            if re.search("^installed: ", …
                …
                command = 'refresh'
                self._view.updateStatus(_("refreshing snap %s" % snap))
            else:
                command = 'install'
                self._view.updateStatus(_("installing snap %s" % snap))
            try:
                self._view.processEvents()
…
This would make the strings easily translatable.

AO (aofrl10n) said : #2

Hi Manfred,

Thanks for your prompt answer.

Best,

AO

Adolfo Jayme (fitojb) said : #3

Bug 1824005 has been fixed now.

Can you help with this problem?

Provide an answer of your own, or ask AO for more information if necessary.

To post a message you must log in.