Sparkle

How can I get source with all the fixes?

Asked by jkbull

I went to http://github.com/andymatuschak/Sparkle and clicked the Download button, chose a .zip file, and downloaded it. The file is named "andymatuschak-Sparkle-7bfbe83d87a88d106a935858a569414132b01614.zip"

It expanded into a similarly named folder with a modification date of September 6, 2009 which contains the Sparkle source.

However, at least two bugs whose status is "Fix committed" appear to still be in this version:

#377834 MoreInfoView summary appears empty in SUUpdatePermissionPrompt in non-English locales
     and
#396635 Sparkle doesn't build on Leopard

The first was fixed on 2009-08-21, the second on 2009-07-11.

Did I just happen to find two reversions, or is the version I downloaded not the most current?

Question information

Language:
English Edit question
Status:
Solved
For:
Sparkle Edit question
Assignee:
No assignee Edit question
Solved by:
jkbull
Solved:
Last query:
Last reply:
Revision history for this message
Andy Matuschak (andymatuschak) said : 		#1

I just verified that #377834 is fixed. Which language was giving you problems?

And I know a lot of Sparkle-y people develop on Leopard, so I feel like I'd be hearing a lot more yelling if #396635 were still broken.

I just downloaded the .zip as you mention, and the couple .nibs I checked for the former bug look fine.

Is it possible that you had a cached copy in your builds folder?

Revision history for this message
jkbull (jkbullard) said : 		#2

It was incredible bad luck, not a cached copy. Sorry I didn't do more testing and/or wasn't more specific.

I downloaded again, and did a build, and had the #396635 problem again. Then I realized I was building a "Release", and did a "Debug" build -- which worked. Sorry for the confusion. But probably the compiler should be set to GCC 4.0 in "All configurations", not just "Debug".

And the one non-English language I had tried was Spanish. I checked, and it still has the #377834 bug. I tried German, and that was fine. (I had assumed the problem with #377834 was a code problem, not a nib problem, so I hadn't tried any other languages before. Sorry for jumping to conclusions.) By the way, the Spanish nib has one other issue -- the "DO NOT LOCALIZE" paragraph runs into the text for the checkbox.

So it looks like I tested two things that were fixed partially, and found the parts that weren't fixed!

I was worried that the "Download" button wasn't getting me the most recent versions or something, but feel better now.

So thanks.

And thanks, in general, for Sparkle. It's great!

Revision history for this message
Andy Matuschak (andymatuschak) said : 		#3

Ah, thanks. Fixed in af37928.