SoundConverter doesn't name files with DiscNumber

Asked by Ivan Tišljar on 2019-02-27

I am using Ubuntu 18.10 and SoundConverter 3.0.0, which is installed through ubuntu repo.
I've set up custom file naming scheme, which is:
{Artist} - [{Date}] {Album}/{DiscNumber}{Track} - {Title}
And in 'preview' I've got the right name, such as 201 - {Title}.opus (as I am using opus as output).
Original files are properly tagged, and they have discnumber tag, and it's showing properly on Windows machine in foobar. But when converting, instead discnumber I get 0, so the filename is 001 - Songname.opus. This is not good.
Originals are stored on NAS shared through Samba, and I added them to converter via drag'n'drop.
This is output from metaflac --list command, only tag part:

METADATA block #3
  type: 4 (VORBIS_COMMENT)
  is last: false
  length: 470
  vendor string: CUETools FLACCL 2.1.6
  comments: 18
    comment[0]: ALBUM=Pirate's Choice
    comment[1]: ARTIST=Orchestra Baobab
    comment[2]: CDTOC=6+96+99F1+12249+1C020+237B8+2B329+340BD
    comment[3]: DATE=1989
    comment[4]: DISCNUMBER=1
    comment[5]: GENRE=World
    comment[6]: LABELNO=WCD063
    comment[7]: ORGANIZATION=World Circuit
    comment[8]: RELEASE DATE=2001-10-01
    comment[9]: RELEASECOUNTRY=GB
    comment[10]: TITLE=Coumba
    comment[11]: DISCTOTAL=2
    comment[12]: TRACKTOTAL=6
    comment[13]: TRACKNUMBER=2
    comment[14]: replaygain_album_gain=-2.10 dB
    comment[15]: replaygain_album_peak=1.000000
    comment[16]: replaygain_track_gain=-3.03 dB
    comment[17]: replaygain_track_peak=0.997528

What to do?

Question information

Language:
English Edit question
Status:
Solved
For:
SoundConverter Edit question
Assignee:
No assignee Edit question
Solved by:
Ivan Tišljar
Solved:
2019-04-23
Last query:
2019-04-23
Last reply:
2019-04-01
Siebren Weertman (siebren-w) said : #1

I found out what was wrong I think with a print in gstreamer.py. disc-number is not a tag, but album-disc-number is.
The whitelisted disc-number entry is wrong.

Siebren Weertman (siebren-w) said : #2

I made a pull request on github that fixed the issue for me.
Let's hope it doesn't introduce unforeseen bugs because I didn't test every type of tagging, it gets accepted soon and added to the distro repos.

GautierPortet (kassoulet) said : #3

You are right : https://github.com/GStreamer/gstreamer/blob/master/gst/gsttaglist.h#L735

Note that disc-count is to be changed also, I'm commiting the change.

Thank you !

Ivan Tišljar (itisljar) said : #4

:) what can I do on my version to correct the issue? I have Ubuntu Mate 18.10 and SC 3.0.0

Siebren Weertman (siebren-w) said : #5

You can look at the changes in git and copy the changes.
The changes in question are this one from me: https://github.com/kassoulet/soundconverter/commit/1c84a29ad0f8d6a493b5a43c880ffa5cf8de804c
And a further fix for album disc count:
https://github.com/kassoulet/soundconverter/commit/9e2f724821550aad2e0764249a437c1deb7a347c

GautierPortet (kassoulet) said : #6

Fixed in 3.0.2

Ivan Tišljar (itisljar) said : #7

I've made the changes on files listed, and it converts as it should. What can I do to get newest version of software (3.0.2) in Ubuntu repos?