Java - click(Rectangle) ought to throw exception
Probably i'm stupid, but twice now I've tried to call
region.click(rect)
where rect is java.awt.Rectangle, which is not a supported target type.
The function simply does nothing and returns 0 (which i ignore).
Don't you suppose it would be better if it throws FindFailed? or else UnsupportedTarg
private <PSIMRL> Location getLocationFrom
if (target instanceof Pattern || target instanceof String || target instanceof Image) {
Match m = find(target);
if (m != null) {
if (isOtherScreen()) {
return m.getTarget(
} else {
return m.getTarget();
}
}
return null; <======== SHOULD BE A THROW FINDFAILED
}
if (target instanceof Match) {
return ((Match) target)
}
if (target instanceof Region) {
return ((Region) target)
}
if (target instanceof Location) {
return new Location((Location) target);
}
return null; <======== SHOULD BE A THROW BAD TARGET TYPE
}
I can't see any situation where return null is helpful. I think a throw is better.
Question information
- Language:
- English Edit question
- Status:
- Solved
- For:
- SikuliX Edit question
- Assignee:
- No assignee Edit question
- Solved by:
- RaiMan
- Solved:
- Last query:
- Last reply: