5.5 fix for fil_rename_tablespace() bug in Percona 5.1?

Asked by Troy on 2012-02-19

We're using Percona 5.1 and planning to move to Percona Server 5.5. Along the way, we ran into a 5.1 bug that Mark Callaghan submitted a patch for (to Sun/Oracle 5.1), and were wondering if anyone knew whether the bug or the fix also applies to Percona 5.5.

The bug is MySQL #62100: http://bugs.mysql.com/bug.php?id=62100 (patch is attached to that bug).
Also #64144: http://bugs.mysql.com/bug.php?id=64144 ("rename table a to b ignores failures in fil_rename_tablespace")

It manifests in the message:
120120 18:15:39 InnoDB: Warning: problems renaming 'db/__osc_new_zz' to 'db/zz', 24998 iterations
InnoDB: Warning: tablespace './db/__osc_new_zz.ibd' has i/o ops stopped for a long time 25105

.. repeating ~25,000 times when a table is renamed, and the server hanging during that time.

To quote the patch's summary:
    "The problem is that fil_rename_tablespace can timeout and return an error that is ignored. The ignored error is not reported to the user. The timeout occurs when there are pending writes for the renamed tablespace but the writer threads are not started. They are not started because the doublewrite buffer is not full and any attempt to request more writes and make it full are blocked by the stop_ios check in fil_mutex_enter_and_prepare_for_io."

I've checked storage/innobase/fil/fil0fil.c in 5.5.15-rel21.0 and checked bazaar, and neither has a literal application of this patch. I assume it hasn't been applied (or better, simply isn't applicable), but figured I'd check whether anyone knew for sure. Thanks.

Question information

Language:
English Edit question
Status:
Solved
For:
Percona Server Edit question
Assignee:
No assignee Edit question
Solved by:
Alexey Kopytov
Solved:
2012-02-28
Last query:
2012-02-28
Last reply:
2012-02-20
Best Alexey Kopytov (akopytov) said : #1

Troy,

I think the problem applies to 5.5 as well.

Troy (c-tron-v) said : #2

Thanks Alexey Kopytov, that solved my question.