OpenShot Video Editor

Curiosity about code

Asked by angelo

I was having an overview of Openshot 1.4.0 source code, (tarball downloaded from site). In file MainGTK, line 2217, I found:

                if isResize:
   # toggle to arrow
   self.tlbArrow.set_active(True)
  else:
   # toggle to razor
   self.tlbResize.set_active(True)

I notice that the comment of 'else' branch is inconsistent with the code (razor for resize tool).
My questions are:

1. Is this wanted, or is it a bug?
2. Why TAB key only toggles Arrow tool and Resize tool? Shouldn't Razor also be in TAB order?
3. I looked at this code because I wanted keyboard shortcuts for selecting tools. How should I have understood that TAB key selects tools?

Thank you

Question information

Language:
English Edit question
Status:
Solved
For:
OpenShot Video Editor Edit question
Assignee:
No assignee Edit question
Solved by:
Jonathan Thomas
Solved:
Last query:
Last reply:
Revision history for this message
Best Jonathan Thomas (jonoomph) said : 		#1

Hi, thanks for the question. This particular feature was programmed to just toggle between "resize" and "arrow", because they were the 2 most common functions. This is not the default behavior of clicking "TAB", but rather a specific work-flow built into OpenShot. Hopefully that makes sense.

Revision history for this message
angelo (a-francabandiera) said : 		#2

Thanks Jonathan Thomas, that solved my question.