Odoo Addons (MOVED TO GITHUB)

account/test/ contains private code

Asked by Numérigraphe

account/test/test_parent_structure.py (committed by Fabien rev 2297) contains a script which checks something on accounts, on a fixed database which probably exists on his machine.
IMHO it should be made generic and converted into a XML unit test file, or removed altogether.
Lionel.

Question information

Language:
English Edit question
Status:
Solved
For:
Odoo Addons (MOVED TO GITHUB) Edit question
Assignee:
No assignee Edit question
Solved by:
Numérigraphe
Solved:
Last query:
Last reply:

This question was originally filed as bug #515419.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) said : 		#1

Hello Lionel,

Its a part of the automated tests we will have to build for openerp.

Thanks.

Revision history for this message
Numérigraphe (numerigraphe) said : 		#2

Would you care to explain a bit more?
What does it test?
How is the test going to be launched on the integration server? Can launch it as-is on our own workstations?
Are you sure it can't be turned into a standard unit-test we can all use?
Lionel.

Revision history for this message
Fabien (Open ERP) (fp-tinyerp) said : 		#3

It tests the Preorder Traversal Tree system. It's not ready to be automated, but we may improve it.

Revision history for this message
Numérigraphe (numerigraphe) said : 		#4

Thanks for your answer. In my very humble opinion it should be automated indeed.
Lionel