Odoo Addons (MOVED TO GITHUB)

New code

Asked by Milan Tribuson

Hello!

What is the best way to contribute to OpenERP Addons code? I've written a code for checking VAT code for Croatia. I've modified base_vat module and tested it and everything works fine. What is the standard procedure for branching and proposing to merge?
I've done this:
- pulled last revision from openerp addons trunk
- created my branch
- pushed openerp files to my branch
- made changes to base_vat
- commited to my branch
- pushed changes to my branch

So, i want to know what is the standard procedure to do this? Do I have to create a branch under openerp addons code? Do I have to report a bug and then connect my branch to it before proposing to merge?
My branch now contains all the modules and revisions. Do i have to take only the module I'm working with and can I work with a branch that has all the old revisions?

Thank you in advance!

Question information

Language:
English Edit question
Status:
Answered
For:
Odoo Addons (MOVED TO GITHUB) Edit question
Assignee:
No assignee Edit question
Last query:
Last reply:
Revision history for this message
Kyle Waid (midwest) said : 		#1

You have to submit code to launchpad and propose your branch for merging. It will be reviewed by the openerp core team for possibly merging it into the trunk

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) said : 		#2

Hi,

you need to push the branch to Launchpad. This branch will contain all the code and revisions. If you request a merge on Launchpad against the leading branch, the resulting page on Launchpad will show a clean diff (if everything went well).

There is also a page on this in the OpenERP documentation:

http://doc.openerp.com/v6.0/contribute/15_guidelines/contribution_guidelines.html

Cheers,
Stefan

Revision history for this message
Milan Tribuson (milan-infokom) said : 		#3

Ok, I've made a branch, made changes to it, reported a bug and linked the branch to the bug.
Bug: https://bugs.launchpad.net/openobject-addons/+bug/847639
Branch: https://code.launchpad.net/~openerp-community/+junk/base_vat_hr_check

Only thing is: i can't see the option to propose the change for merging? How do I do that?

Revision history for this message
Lorenzo Battistini (elbati) said : 		#4

Your branch must be part of the openobject-addons project.
Then, you'll see the 'propose for merging' link on your branch page.

Revision history for this message
Milan Tribuson (milan-infokom) said : 		#5

Thanks! Got it now! :)

Can you help with this problem?

Provide an answer of your own, or ask Milan Tribuson for more information if necessary.

To post a message you must log in.