Creating an invoice from a sale order ; a field is not copied in the right destination

Hello forstera ,

Simple you need to create your own module where you can inherit the class sale_order class and override the method.
If you are new in python and do not aware with tiny framework use the following document links:
http://doc.openerp.com/developer/index.html#book-develop-link
http://doc.openerp.com/developer/1_2_module_development/3_Inheritance.html

Hope this will help you.

Thanks.

Hello vra,
Ok, I'm going to try to override the function _make_invoice().

Thanks for your help

Hello,

I spend 3 hours trying to inherit sale.order and just 1 method but it seems this is too hard for me for the while. I read many python docs but everything fails ...

I had my filename with the same name as the inherited one (sale.py) so I changed it because I don't know if this can be a cause of error ..

I just have the following class which is working fine :

class sale_order(osv.osv):
     _inherit = "sale.order"
 _defaults = {
        'print_total' : lambda *a: 1,
     }

 _columns = {
        'print_total' : fields.boolean('Impression du total',required=False,translate=False),
        'mw_contact': fields.many2one( 'res.partner.contact', 'Contact' ),
        'validite': fields.char('Validite', size=64),
        'date_offre':fields.date('Date offre',required=False, translate=False),
        'date_livraison':fields.date('Date livraison',required=False, translate=False),
        'so_remarques_ids': fields.one2many('remarques.so', 'so_id', 'Remarques'),
        'remarque_offre': fields.text('Remarques offre', required=False, translate=False),
        'remarque_ccde': fields.text('Remarques confirmation de commande', required=False, translate=False),
        'remarque_bl': fields.text('Remarques bulletin de livraison', required=False, translate=False),
        }

sale_order()

But now, I'd like to add a method from the inherited class (sale.order) to modify it.Here's the original method :

    def _make_invoice(self, cr, uid, order, lines, context={}):
        a = order.partner_id.property_account_receivable.id
        if order.payment_term:
            pay_term = order.payment_term.id
        else:
            pay_term = False
        for preinv in order.invoice_ids:
            if preinv.state not in ('cancel',):
                for preline in preinv.invoice_line:
                    inv_line_id = self.pool.get('account.invoice.line').copy(cr, uid, preline.id, {'invoice_id': False, 'price_unit': -preline.price_unit})
                    lines.append(inv_line_id)
        inv = {
            'name': order.client_order_ref or order.name,
            'origin': order.name,
            'type': 'out_invoice',
            'reference': "P%dSO%d" % (order.partner_id.id, order.id),
            'account_id': a,
            'partner_id': order.partner_id.id,
            'address_invoice_id': order.partner_invoice_id.id,
            'address_contact_id': order.partner_order_id.id,
            'invoice_line': [(6, 0, lines)],
            'currency_id': order.pricelist_id.currency_id.id,
            'comment': order.note,
            'payment_term': pay_term,
            'fiscal_position': order.partner_id.property_account_position.id
        }
        inv_obj = self.pool.get('account.invoice')
        inv.update(self._inv_get(cr, uid, order))
        inv_id = inv_obj.create(cr, uid, inv)
        data = inv_obj.onchange_payment_term_date_invoice(cr, uid, [inv_id], pay_term, time.strftime('%Y-%m-%d'))
        if data.get('value', False):
            inv_obj.write(cr, uid, [inv_id], data['value'], context=context)
        inv_obj.button_compute(cr, uid, [inv_id])
        return inv_id

I just would like to change the field
'reference': "P%dSO%d" % (order.partner_id.id, order.id),

but impossible to inherit this function, As soon as I add it to my sub-class, system hangs when restarting ...
If someone can give me some informations on what I do false, I'd be very gratefull

Best Regards

I had the same problem where i wanted the client order ref in invoice. If you notice that on Sale Order form in history tab you will see a table that shows associated invoices. I suggested (Question # 99471) this to openerp team that if a relationship already exists between sale order and invoice then why not show sale order as a link on invoice form as well. Well i had done that at my end. And i am able to print the customer ref on invoices as well. Specially in India we need to print customer order ref and customer order date on invoices to show our customer for our quick turnaround times.

No need to override any method of invoice or sale order. Do this:

In Sale.py file of sale module, append the following code at the end of file:

class account_invoice(osv.osv):
    _inherit = "account.invoice"
    _columns = {
        'saleorder_ids': fields.many2many('sale.order', 'sale_order_invoice_rel', 'invoice_id', 'order_id', 'Sale Order'),
    }
account_invoice()

Now you have added link to sale order on invoice object. Next to show this on invoice form. From Administration menu you can edit the xml for view account.invoice.form and add rhe below code after the last "</page>" tag in that xml:

<page string="Origin">
<separator colspan="4" string="Sale Orders"/>
<field name="saleorder_ids" nolabel="1" colspan="4" readonly="1"/>
</page>

Hope this helps. Any questions then mail me at <email address hidden>

Oh yes restart the server after modifying the python code.

Hello,
Thank you very much for the informations; I think they're very useful. But I really need to overwrite the method def _make_invoice() because I'd like to change the content of one field.
As I said, the field 'name' is the field that is used in the accounting to reference a journal entry. This field has the now the value of the customer's own sale order number. So, if we have in the Accounting a journal entry with the customer's sale.order, the account number and the value. People from the Accounting can't do anything with that. They have, for each entry, delete this valeue and replace it with the name of the customer and our own sale order's number.
That's why I'd like to modify that by overwriting this method but really have problems to solve that

I really appreciate your help
Thanks

Hello forstera ,

Change your code by following manner:
create your own module and create one py file for this code.Do not forget to put dependency of sale module in __terp__.py file in your new module.

class sale_order(osv.osv):
          _inherit = "sale.order"

         def _make_invoice(self, cr, uid, order, lines, context={}):
               inv_obj = self.pool.get('account.invoice')
               inv_id = super(sale_order, self)._make_invoice(cr, uid, order, lines,context=context)
               inv_obj.write(cr, uid, inv_id,{'reference':("P%dSO%d" % (order.partner_id.id, order.id) )=><do it your changes here>})
               return inv_id
 sale_order()

Hope this will help you.

Thanks.

Hello Vra,
Great !
thanks so much for your help. I'm going to test that next week and keep informed.

Thanks again for a so great help !!

regards

Hello vra,

I'm trying your solution but for the while, but for a reason I don't understand, the system hangs. I can write the name of the function and thre return value :

def _make_invoice(self, cr, uid, order, lines, context={}):
return inv_id

I can update the module in this state, no problem. But the simple fact to add a line inside this function (whatever it is) makes the system to hang when I update

Couldn't load module new_sale_order
...
debug_rpc:exception:u''
debug_rpc:service:'object'
debug_rpc:method: 'execute'

Any idea ?
thanks very very much for your help

Hello Forster,

Can you provide me your code which you did it in new module (new_sale_order)?
I will try it in my code and check.

Thanks.

Here it is (this is very kind to you) :

# -*- encoding: utf-8 -*-
##############################################################################
# .. removed to make place to post
###############################################################################

import netsvc
from osv import osv, fields
import time
import pooler

class sale_order(osv.osv):
 _inherit = "sale.order"

 def _make_invoice(self, cr, uid, order, lines, context={}):
               inv_obj = self.pool.get('account.invoice')
               inv_id = super(sale_order, self)._make_invoice(cr, uid, order, lines,context=context)
               inv_obj.write(cr, uid, inv_id,{'reference': "Testing value"})
        return inv_id
sale_order()

Hello Forster,

I have successfully run this code and reference field which you did write.One more thing i want to tell you that the reference field is not exist in form view of customer invoice.
This function will only call (from action_invoice_create) when you select Shipping policy 'Shipping & Manual Invoice'.
From Picking policy, stock will create invoice (function is defined in 'stock.py' code) with the help of create invoice wizard.

I am surprised for system hang problem.Try to create new database and check.

Thanks.

Hello,
I'm going to try that and keep you informed ...
Thanks very much

Successfull, too great !!

Thanks for the informations you just gave, very very useful.

Before, I had more things defined with the method _make_invoice() like fields. So I completely made a new module with just the function and it's working.

So, to make such functions, do I have to write some modules just for them or can I mix functions and other things (like adding new fields) ?

Thanks very very much for your very useful help :)

Thanks vra (openerp), that solved my question.

Akshay Jain,

Thank, you solution was exactly what I needed. Now I need to print the client_order_ref from the sales order on the invoice report form. Can you tell me how to do so ? I need the object name to use in the rml file.