NUnit V2

I developed a small feature, preferred way to contribute?

Asked by Csaba Toth

I developed a small feature: a Find menu item into the View > Tree submenu. It has a Ctrl+F shortcut, and pops up a simple modal dialog with a textedit and a listbox. When the user types into the listbox the code crawls through the test treview and loads the matching elements (String.Contains, case insensitive) into the listbox. If the user double clicks on any item of that listbox the particular element will be selected in the treview and it'll be scrolled there.
The reason I developed this because we have 8500+ tests in our project and the treeview is huge (you can imagine), several levels deep in hierarchy.
The modification affects only a few files. I can pack them and send it to some maintainer. Currently it is based on 2.6.2 src (the downloadable). I don't think that I'll have time to contribute more, I'm too busy unfortunately, so a branch maybe an overkill for that. But I can do it if needed. I'd be happy if that feature will be included in the main branch. I haven't written tests for it (lack of time also).
Let me know what should I do.

Question information

Language:
English Edit question
Status:
Solved
For:
NUnit V2 Edit question
Assignee:
No assignee Edit question
Solved by:
Charlie Poole
Solved:
Last query:
Last reply:

This question was reopened

Revision history for this message
Csaba Toth (csaba-toth) said : 		#1

The dialog's main purpose is only to make it easy to navigate in a huge tree. Find a test in giant tree.
The user can click the modal dialog after he/she found the test and selected it. It's simple.
When the user types 4 or less character long search phrase, only 12 hits returned. That was needed in case of a giant tree. Some people may experience that as a bug, so this needs thinking. I meant to preserve CPU load with that originally.

Revision history for this message
Csaba Toth (csaba-toth) said : 		#2

Correction: The user can _close_ the modal dialog after he/she found the test and selected it. The dialog doesn't have OK or Cancel buttons, the user can close it with the window close button. Keep things simple.

Revision history for this message
Best Charlie Poole (charlie.poole) said : 		#3

Hi Csaba,

We welcome contributions and yours sounds interesting.

There is one small problem. Another contributor is already working on
a Find feature, which works a bit differently, so the two will need to
be coordinated in some way. The in-process find feature simply
provides a text box into which search strings are typed. There is no
list of items that might be selected yet. Your list might be made to
work as part of this feature, by converting the list to a dropdown
selection, similar to what most browsers now do. If you want to look
at the current state of the Find feature, it's here:
https://code.launchpad.net/~anuraj.p/nunitv2/bug-787550

BTW, the best location for discussing how to contribute is on the
nunit-developer list on google groups. For more broad discussions like
"Should NUnit have such and such a feature?" we use nunit-discuss,
also on google.

Since you say your time may be limited, feel free to send me a zip of
your changes whenever you run out of it. I would then try to merge it
in, if possible, with the feature being developed.

Charlie

On Thu, Jan 10, 2013 at 3:45 PM, Csaba Toth
<email address hidden> wrote:
> Question #218884 on NUnit V2 changed:
> https://answers.launchpad.net/nunitv2/+question/218884
>
> Csaba Toth gave more information on the question:
> Correction: The user can _close_ the modal dialog after he/she found the
> test and selected it. The dialog doesn't have OK or Cancel buttons, the
> user can close it with the window close button. Keep things simple.
>
> --
> You received this question notification because you are an answer
> contact for NUnit V2.

Revision history for this message
Csaba Toth (csaba-toth) said : 		#4

I'm very happy that such a feature will be developed in any form, even if my solution won't be a part of it. Today I'll try to pack the touched files, there aren't too many.

Revision history for this message
Csaba Toth (csaba-toth) said : 		#5

Thanks Charlie Poole, that solved my question.

Revision history for this message
Csaba Toth (csaba-toth) said : 		#6

I sent the package to the first e-mail address which is on your profile.

Revision history for this message
Csaba Toth (csaba-toth) said : 		#7

Thanks Charlie Poole, that solved my question.

Revision history for this message
Csaba Toth (csaba-toth) said : 		#8

I just accidentally reopened the Question...