I am generally +1 with SRUing this, BUT this is a special in a few ways:
1/ In order to land this in Focal, we first need to apply it to Impish and Hirsute (according to SRU process), as ddstreet mentioned.
2/ We are already post Feature Freeze for Impish and this is adding new functionality IMO (in contrast to fixing a bug). So I wonder if we'd need a Feature Freeze exception – that should be clarified with the release team.
3/ The debdiff looks good to me at first glance, BUT: We need to also inject the "gboolean ignore_carrier" field into the "net_definition" struct before the new offload fields (i.e. parse.h change from this commit https://github.com/canonical/netplan/commit/d4884cfd40e1e33540b274371c3272df6595d22c). Otherwise this patch will break ABI compatibility once the next upstream release would be SRUed...
I am generally +1 with SRUing this, BUT this is a special in a few ways:
1/ In order to land this in Focal, we first need to apply it to Impish and Hirsute (according to SRU process), as ddstreet mentioned.
2/ We are already post Feature Freeze for Impish and this is adding new functionality IMO (in contrast to fixing a bug). So I wonder if we'd need a Feature Freeze exception – that should be clarified with the release team.
3/ The debdiff looks good to me at first glance, BUT: We need to also inject the "gboolean ignore_carrier" field into the "net_definition" struct before the new offload fields (i.e. parse.h change from this commit https:/ /github. com/canonical/ netplan/ commit/ d4884cfd40e1e33 540b274371c3272 df6595d22c). Otherwise this patch will break ABI compatibility once the next upstream release would be SRUed...