why doesn't loggerhead's templates include the favicon?

Asked by razamatan on 2011-01-08

i see the favicon_app stuff referenced in the app/*.py files.

my current trunk checkout shows no <link rel="icon" ...> for the favicon in the static/images/favicon.ico file for all of the pt templates.

should i just include it in my checkout? is there a way for me to create my own template for loggerhead?

Question information

Language:
English Edit question
Status:
Answered
For:
loggerhead Edit question
Assignee:
No assignee Edit question
Last query:
2011-01-24
Last reply:
2011-01-25
Launchpad Janitor (janitor) said : #1

This question was expired because it remained in the 'Open' state without activity for the last 15 days.

razamatan (razamatan) said : #2

reopening.

Martin Pool (mbp) said : #3

It looks to me like like the favicon configuration just turns up through the web server responding to /favicon.ico. It does not put in a <link rel=> tag. This is a somewhat archaic approach so it would be better to add it to the templates. Would you like to put up a merge proposal that adds it?

razamatan (razamatan) said : #4

the diff is pretty straightforward:

=== modified file 'loggerhead/templates/browse.pt'
--- loggerhead/templates/browse.pt 2009-10-17 06:55:25 +0000
+++ loggerhead/templates/browse.pt 2011-01-09 12:33:52 +0000
@@ -4,6 +4,8 @@
     <title>loggerhead branches</title>
     <link rel="stylesheet"
           tal:attributes="href python:branch.static_url('/static/css/global.css')" />
+ <link rel="shortcut icon"
+ tal:attributes="href python:branch.static_url('/static/images/favicon.ico')" />
   </head>

   <body>

=== modified file 'loggerhead/templates/directory.pt'
--- loggerhead/templates/directory.pt 2010-04-13 23:35:01 +0000
+++ loggerhead/templates/directory.pt 2011-01-09 12:33:54 +0000
@@ -4,6 +4,8 @@
     <title tal:content="string:Browsing ${name}"></title>
     <link rel="stylesheet"
           tal:attributes="href python:static_url('/static/css/global.css')" />
+ <link rel="shortcut icon"
+ tal:attributes="href python:branch.static_url('/static/images/favicon.ico')" />
   </head>
   <body>
     <div id="loggerheadCont">

=== modified file 'loggerhead/templates/macros.pt'
--- loggerhead/templates/macros.pt 2009-06-24 02:35:46 +0000
+++ loggerhead/templates/macros.pt 2011-01-09 12:34:24 +0000
@@ -9,6 +9,8 @@
     <title metal:define-slot="title"></title>
     <link rel="stylesheet"
           tal:attributes="href python:branch.static_url('/static/css/global.css')" />
+ <link rel="shortcut icon"
+ tal:attributes="href python:branch.static_url('/static/images/favicon.ico')" />
     <tal:comment condition="nothing">
       <script type="text/javascript"
               src="http://getfirebug.com/releases/lite/1.2/firebug-lite-compressed.js"></script>

razamatan (razamatan) said : #5

made a formal merge request. changed the favicon in the macro.pt to be a little different so the favicon changes if it's in an actual repo vs. browsing around.

Can you help with this problem?

Provide an answer of your own, or ask razamatan for more information if necessary.

To post a message you must log in.