two seperate /help menus?

Asked by box2 on 2009-05-03

I'm adding some custom /commands and I've found that there are two locations for handling /help and associated client commands. One for if you type them into public hub (in linux/hub.cc starting at line 868) and one for inside of private messages (in linux/privatemessage.cc starting at line 290). This is in the current trunk version, revision 304 or whatever it is now.

I was wondering why there are two seperate locations for specifying the same commands? Why not unify the help menu into one file and if required, subtract or add the extra available commands based on if it's a public hub message or inside a PM.

(P.s. I don't see why you would need to subtract the extra /commands in a pm, I do most of my commands there in a pm to myself in case I typo or something stupid it doesn't show for everyone in the hub).

Question information

Language:
English Edit question
Status:
Solved
For:
LinuxDC++ Edit question
Assignee:
No assignee Edit question
Solved by:
Steven Sheehy
Solved:
2009-05-03
Last query:
2009-05-03
Last reply:
2009-05-03
Best Steven Sheehy (steven-sheehy) said : #1

It's very simple: bad design. We've planned for a long time to make a separate class to contain all chat functionality that hub and pm can share, but we haven't gotten around to it yet.

box2 (linuxdcpp) said : #2

Thanks Steven Sheehy, that solved my question.