Comment 14 for bug 361735

Revision history for this message
Razzloss (razzloss) wrote :

Ok, I think most of the issues discussed are now committed.
* Manpage: Check
* Removed argument handling and storing from WulforUtils: Check
* There's now --show, which will call gtk_present on the window if combined with other options, and --existing, which will only sends commands to already running instance, if ldcpp isn't already running the other options are ignored and program exits.
* If no arguments are given and linuxdcpp is running it behaves as --show.
* Argument description added.
* Context and parsed args freed.
* N_() -added for descriptions and argument descriptions. Not for long args (and I hope those won't be translated anyway...)
* MainWindow::createIPC method added.
* Dropped the mw::handleCmdArgs... Instead added a handleArguments function to wulfor.cc which will be used incase the profile is locked and after wulformanager::start. handleArgs will write the IPC commands to pipe and ExternalData will handle them. Don't know if using arg callback would be any cleaner solution, since we can't handle the arguments while parsing (core & GUI needs to be started for -c & -m args, and I don't think we can delay parsing long enough (-V and -e needs to be handled before core startup)). So all args are first parsed to CommandlineArgs structure and handled from there.

Let me know if I missed something. And someone please test this and compare the behavior to what's documented. I'm not sure I've tested all the possibilities with the latest version.

--RZ