Comment 10 for bug 361735

Revision history for this message
Steven Sheehy (steven-sheehy) wrote :

I definitely don't like the command line argument data stored inside WulforUtil. The purpose of any util class is to provide static methods and shouldn't hold state (unless that state is static, non-changing data that needs to be used multiple times). I think we need to pass it to MainWindow after it is created in wulfor but before it enters the main loop. Another alternative is to create a new OptionsHandler class and move most of this logic to it.

--magnet and --connect need an arg description (for example, URI or <uri> for magnet)

Command line options need to be added to man page

Summary and description from man page need to be added (is there a way to keep these in sync automatically?)

I think we need to call setlocale before parsing options so the strings are converted properly to utf8

I think we need to g_option_context_free

Shouldn't we support multiple magnets and multiple hubs using only -c and -m? Or is this not possible? I don't think it makes sense to allow them to be passed without the -c/-m.

"Should we make show the default and remove the lock error message?" Yes.

Can you add N_() around the option text?

What about --existing instead of --show like xchat?

Setting up the IPC should probably be in its own method to keep the constructor from getting too big.

Did you happen to look at using dbus for IPC? It seems to be more standardized for this purpose, so we may want to look at migrating to that in the future. I don't think it will add a dependency since GTK+ itself depends on it.