Code review process confusing (incorrect diff?)

Asked by Jason Spashett on 2009-03-30

I pushed up a change on branch asked for it to be reviwed.

A comment was put against the proposal, which I agreeded with and I therefore re-worked the change and pushed it back.After which I submitted it for re-review, but now I see that the diff for the proposal is the old one and not that contains the new changes. If you look at the branch history you can see my new changes, but not my new diff underneath. This is confusing to me and possibly "wrong."

Proposal is:

Question information

English Edit question
Launchpad itself Edit question
No assignee Edit question
Last query:
Last reply:
Curtis Hovey (sinzui) said : #1

I too was confused when I pushed and checked the diff on the website. The merge proposal's diff is *not* regenerated after a push. The diff only reflects the changes at the time the merge proposal was made.

Reviewers must make new diffs from your branch, you include an incremental diff (that will not be coloured) in your comment.

Can you help with this problem?

Provide an answer of your own, or ask Jason Spashett for more information if necessary.

To post a message you must log in.