code browser doesn't show newly add files for a revision

Asked by SuperMMX

I didn't find any hints on the page, it shows just the modified files, but not the newly added files. I want to see all changes to that revision on the same page. Is this a bug?

Question information

Language:
English Edit question
Status:
Solved
For:
Launchpad itself Edit question
Assignee:
No assignee Edit question
Solved by:
SuperMMX
Solved:
Last query:
Last reply:
Revision history for this message
Tim Penhey (thumper) said :
#1

I think so. I just looked at http://codebrowse.launchpad.net/~bzr/bzr/trunk/revision/3055 where Ian added a number of files (and images), but the detailed listing only shows modifications.

Revision history for this message
Launchpad Janitor (janitor) said :
#2

This question was expired because it remained in the 'Needs information' state without activity for the last 15 days.

Revision history for this message
SuperMMX (supermmx) said :
#3

The status is automatically changed ? There is no answer at all.

Revision history for this message
Michael Hudson-Doyle (mwhudson) said :
#4

Well, at least I didn't really understand what you were complaining about. Can you be more explicit?

Revision history for this message
SuperMMX (supermmx) said :
#5

Sorry about that. I will try to explain it.

A revision will include the changes of newly added file and modified files. Generally a user want to see all the changes of a revision, not only changes of modified files. If you look at the link Tim Penhey gave (http://codebrowse.launchpad.net/~bzr/bzr/trunk/revision/3055), you will find that many new files were added in that revision, but only the diffs of modified files are shown on the bottom part of the page.

Sure you can click specific file to see the file content, but it will be better to see all the files on the same page. I think this is a feature request for loggerhead, because I didn't find this feature by reading its own code via itself (http://www.lag.net/branches/loggerhead/loggerhead_dev/changes).

Did I make myself clear ?

Revision history for this message
Michael Hudson-Doyle (mwhudson) said :
#6

Ah, OK. Hm hm.

I guess the reason that this wasn't done in the first place is that it's not a very interesting _diff_, exactly. But I can also see why you'd want to see everything in one page.

A reason I'm a touch reluctant to do this is that it may lead to the revision page getting rather large, which means slower rendering and more data to shove over the network. But the revision page can get very large anyway (merges from trunk are often very large diffs), so that's a problem that I should think about fixing anyway, and isn't too related to this.

In any case, this should probably be a bug report...

Revision history for this message
SuperMMX (supermmx) said :
#7

Sounds great. Thanks.