Fast code import review.

Asked by xaav on 2011-07-12

Right after I add a code import to one of my projects, it's status shows as reviewed. I don't mean a few minutes, I mean on the very next page load. However, a message shows "New code import created. The code import operators have been notified and the request will be reviewed shortly." There is no way that a human can review a code import that fast. I'm just wondering if anyone is actually reviewing the code import or it is just approved automatically.

Question information

Language:
English Edit question
Status:
Solved
For:
Launchpad itself Edit question
Assignee:
No assignee Edit question
Solved by:
Max Bowsher
Solved:
2011-07-13
Last query:
2011-07-13
Last reply:
2011-07-13
Gary Poster (gary) said : #1

We usually review code imports several times a day (I just reviewed three a few minutes ago), but some people do have pre-approval for their imports, and it sounds like that's what you are encountering.

Max Bowsher (maxb) said : #2

On the other hand, Git and Mercurial bypass the review stage and go straight to Reviewed regardless of who creates them. I suspect no one updated the message box to account for that.

xaav (xaav) said : #3

> On the other hand, Git and Mercurial bypass the review stage and go straight to Reviewed regardless of who creates them. I suspect no one updated the message box to account for that.

Why do these VCS's get special treatment? Just curious.

Best Max Bowsher (maxb) said : #4

For CVS, and especially Subversion, it's fairly easy for novices to specify an URL overly near to the root of the repository, and waste a lot of processing resources and bandwidth if not checked.

For Git and Mercurial, whole repository fetching is the norm, and reasonably efficient, so it's not a problem.

xaav (xaav) said : #5

Thanks Max Bowsher, that solved my question.

xaav (xaav) said : #6

By the way, I imagine it wouldn't be too hard to write a regular expression to verify the URL of the repository.

Just an Idea.