Launchpad itself

Translations cannot be accepted

Asked by Christoph Schmidt

Hi *,

a few days ago I added a .pot and a .po file by automatic import to my project and they are still in the "Needs review" state (https://translations.launchpad.net/priscian/+imports). I don't know who has to review them (apparently it's not me as I can only delete or block them). I beg your pardon if I missed the corresponding chapter in launchpad help, but I don't know what to do to change their state.

Thanks a lot in advance,
Christoph

Question information

Language:
English Edit question
Status:
Solved
For:
Launchpad itself Edit question
Assignee:
Jeroen T. Vermeulen Edit question
Solved by:
Jeroen T. Vermeulen
Solved:
Last query:
Last reply:
Revision history for this message
Jeroen T. Vermeulen (jtv) said : 		#1

Hi,

Manual uploads take human time to review, and match up to possible existing templates. Please consider using bzr integration instead: make sure your .pot and .po files are in your development branch, and have them imported from there. That requires much less human intervention, and is less prone to various other errors and mistakes.

Jeroen

Revision history for this message
Christoph Schmidt (priscian) said : 		#2

Hi Jeroen,

thanks a lot for your response, but I thought I would use automatic import from my bzr branch. At least that's what I configured here: https://translations.launchpad.net/priscian/0.1/+translations-settings. And I added the files via bazaar. I definitely did not import them via the browser interface.

Is there anything wrong with my setup?

Kind regards,
Christoph

Revision history for this message
Jeroen T. Vermeulen (jtv) said : 		#3

I have no idea why they weren't imported. It may be a problem with our system setup. I filed bug 719247 for it.

Meanwhile I approved the template manually so that at least things should work for you while we get this sorted out.

Revision history for this message
Jeroen T. Vermeulen (jtv) said : 		#4

I see now what was missing: the name po/messages.pot doesn't contain any meaningful name, so the approver can't make up a fitting name and domain for the template. We approved your template manually to solve this particular instance of the problem; next we'll fix up the approver to be a bit more aggressive and use the project's name as a template name/domain.

Revision history for this message
Christoph Schmidt (priscian) said : 		#5

Hi Jeroen,

thanks for your answer. What would be a better name for the template? po/priscian.pot?

Thanks a lot,
Christoph

Revision history for this message
Best Jeroen T. Vermeulen (jtv) said : 		#6

That would be perfect, yes. I'm also about to land a change that will automatically use the project name when it can't get a useful name from the template's path. That will give you the same effect as calling it po/priscian.pot but without having to change the filename.

Revision history for this message
Christoph Schmidt (priscian) said : 		#7

Hi Jeroen,

I tried the automatic import again with my new series and the template file po/priscian.pot got imported without problems. But the German translation file po/de.po is again stuck in the "Needs review" state:

https://translations.launchpad.net/priscian/0.2/+imports

Is there anything else I have to do?

Thanks a lot,
Christoph

Revision history for this message
Jeroen T. Vermeulen (jtv) said : 		#8

When I looked just now it was already imported. It probably just took a while; translations go through the classic, asynchronous approver and that one currently has a very large queue to go through on every run.

Revision history for this message
Christoph Schmidt (priscian) said : 		#9

I think that's it.

Thanks a lot !!!

Revision history for this message
Christoph Schmidt (priscian) said : 		#10

Thanks Jeroen T. Vermeulen, that solved my question.