Launchpad itself

Commit author link pointing to wrong account

Asked by Daniel Watkins (credativ)

At https://code.launchpad.net/~daniel-watkins-credativ/openobject-addons/crm_max_fix, the author of the most recent commit is "Daniel Watkins <email address hidden>" which is associated to this account, daniel-watkins-credativ. However, the commit author link points to https://launchpad.net/~daniel-thewatkins.

This email address was previously associated to that account, but is no longer. Diogo Matsubara and maybe Brad Crittenden have already looked into problems I had registering/accessing this account as a result of that, so I suspect this is a related issue.

Also:
< wgrant> Odd_Bloke: Commit authors are tracked as a separate mapping from email addresses to users.

Question information

Language:
English Edit question
Status:
Solved
For:
Launchpad itself Edit question
Assignee:
No assignee Edit question
Solved by:
Tim Penhey
Solved:
Last query:
Last reply:
Revision history for this message
Launchpad Janitor (janitor) said : 		#1

This question was expired because it remained in the 'Open' state without activity for the last 15 days.

Revision history for this message
Daniel Watkins (credativ) (daniel-watkins-credativ) said : 		#2

The problem hasn't disappeared, and I'd still like to know what's going on here.

Revision history for this message
Max Bowsher (maxb) said : 		#3

Hi Daniel,

Total guess here, but is it possible the revision in question was pushed to Launchpad at a time when the email address was associated with the old account?

Revision history for this message
Daniel Watkins (credativ) (daniel-watkins-credativ) said : 		#4

Hi Max,

Thanks for the thought, but the original problem was fixed on the 2nd and the commit is from the 3rd, so I think there's something else going on...

Revision history for this message
Max Bowsher (maxb) said : 		#5

Hi Daniel,

Is it only this particular revision link which is wrongly directed? Could you test by pushing a newly committed revision as each identity? i.e.:

(set your bzr settings to be you personally)
bzr init test1
cd test1
bzr commit --unchanged -m "Dummy revision"
bzr push lp:~daniel-thewatkins/+junk/question123948test
cd ..
(set your bzr settings to be you at credativ)
bzr init test2
cd test2
bzr commit --unchanged -m "Dummy revision"
bzr push lp:~daniel-watkins-credative/+junk/question123948test

Revision history for this message
Daniel Watkins (credativ) (daniel-watkins-credativ) said : 		#6

Done: lp:~daniel-watkins-credativ/+junk/question123948test and lp:~daniel-thewatkins/+junk/question123948test.

The ~daniel-watkins-credativ branch was committed with "bzr whoami" == "Daniel Watkins (credativ) <...>" and then "bzr whoami" == "Daniel Watkins <...>". The first one worked properly, the latter one did not.

So it would appear that it uses the committer name without the email to determine it.

Revision history for this message
Best Tim Penhey (thumper) said : 		#7

Daniel,

The way that Launchpad links revision authors to people is a little different. They are linked once, and once they are linked, they don't look any more.

I'd say that you made your first commits with the revision author:
    Daniel Watkins <email address hidden>
While that email address was still linked to daniel-thewatkins.

Then you created the user daniel-watkins-credativ and moved the email to that account. After that you first used this revision author string:
    Daniel Watkins (credativ) <email address hidden>

This was then linked to the new user. If this is super important to you, we can tweak the stored value.

Tim

Revision history for this message
Daniel Watkins (credativ) (daniel-watkins-credativ) said : 		#8

Hi Tim,

If it's not too much trouble, I'd appreciate it, but don't worry about it too much.

Cheers,

Dan

Revision history for this message
Daniel Watkins (credativ) (daniel-watkins-credativ) said : 		#9

Thanks Tim Penhey, that solved my question.