Comment 25 for bug 988601

Revision history for this message
David Mathog (mathog) wrote :

~suv, yes there may be some other patches mixed in. When I get a chance I will make a list.

uemf_print.c and .h are in there because during development some of those functions were needed to dump
the contents of EMF records to stdout during parsing. I do not believe either file will be needed in production code.

One thing somebody should look at is the change to src/style.h. (At line 181 in the patched file, or
search for the string EMF_DRIVER. ) Here is that change:

/* EMF_DRIVER is a temp work-around
The problem is that SPIPaint is private, but is included in the SPStyle struct, and that is needed in emf-inout.cpp, but the compiler
won't accept it there. If the two conditional lines are moved out of the "private" they end up generating undefined reference
errors.
*/

private:
#ifndef EMF_DRIVER
    SPIPaint(SPIPaint const&);
    SPIPaint &operator=(SPIPaint const &);
#endif // EMF_DRIVER
};

Presumably the two conditional lines of code were needed for something originally, and since EMF_DRIVER would be defined on all platforms, this would break whatever function that was (everywhere). Anyway, comment out the ifndef/endif and
build to see what the errors are. It wasn't obvious to me how to rearrange style.h to fix it, other than by removing these two lines. If I remember correctly EMF_DRIVER was only used here, after its definition in emf-inout.cpp.