Comment 31 for bug 909328

Revision history for this message
John Smith (john-smithi) wrote :

Thanks for all the suggestions, an updated patch is attached.

@LucaDC - good idea, if nothing is found for All or Current Layer, then selected objects are unselected

@Kris
> a call to "g_free(text)" is needed on line 642
Thanks added

>a space in front of the "..."
Have removed the space and "..."

> does not enable the "Replace" button on my system
Replace button is disabled when you check on the "Attribute Name" property. I thought it was a bit too dangerous replacing attribute names. Do you think there a valid use case for replacing attribute names ?

> clicking on the minus at the left of "options" does not resize the dialog to its smaller size
Yes this a common problem, that occurs in several dialogs (Object Properties and Document Properties->Page), unfortunately i dont know how to fix this. Any place where this works correctly ?

> use the canvas selection callback for updating the "xx objects found" label
Sorry not quite understanding this. Do you suggest we update the "xx objects found" label when the selection on canvas changes ? Even when the user changes the selection ?