Comment 36 for bug 171117

Revision history for this message
Robin Battey (zanfur) wrote :

Your pictures contradict some of your statements. If you look at http://mcepl.fedorapeople.org/tmp/after-recursive.png (after your original plugin), and at the http://mcepl.fedorapeople.org/tmp/after-iterative-02.png (after my latest iterative version), you'll see they're the same as each other, and both different than http://mcepl.fedorapeople.org/tmp/before.png (the original) . Your plugin also makes changes due to the clipping issue -- there *is* a visible change.

There was a point where I had a bug (not propagating the transform correctly) that caused the missing text that you see, but I didn't think I'd uploaded that version. I'd go check, but it's fixed in the latest version anyway, so I'll take your word (and evidence!) for it that it was broken. Sorry about that. In any case, our plugins now give the same result, though the iterative version works where the svg depth is greater than 1024 and the recursive one doesn't, and the iterative one has a few more options now. It also runs vastly faster and avoids doing a bunch of changes unrelated to ungrouping that came as part of using the global inheritance-removal script.