Comment 66 for bug 165865

Revision history for this message
John Smith (john-smithi) wrote :

New patch with the following changes

User Preference : Behavior->Markers->Change color of custom markers (default off)
When off custom markers are used as-is, color not changed, and not forked.
Preview for gradient markers shown in list

> Result is that the marker color is not changed (when changing line color)
Yes this is by design and is consistent with the Color Marker extension. This seemed like the best way to allow the user to set the marker color and line color separately. There are some other complications of having auto updates - if you have several lines all using the same color marker, then you update one line color - do you then update all the marker colors or not ? Could add an option for this later.

> Result is that it forks the existing first custom marker with the new color rather than actually using that marker as-is
Should be fixed by new User Preference

> Issue 1: There is an actual problem though if you toggle between markers in the custom section it continues (forking)
Forking only happens now with the user Preference above "on"

>Issue 2: .... it eventually gives them different names
Should be fixed

> gradients on strokes
If you check the def of the marker, it actually has the same gradient link as the line. Linear gradients seems to mostly render the first stop color, radial gradients dont work well. Not sure how to deal with this, since there is no way to independently tweak the gradient of the marker (stops, location etc) i dont think there is a perfect solutions to this. Any ideas ?

> Gradient previews are not reflecting what's on-canvas
Should be fixed