using pano_modify, I can only set FOV to int values (I want to set it to a double)

Asked by George

Hi,

I am using the command line tools to create a panorama of the correct size. The line I am having difficulty with is:

pano_modify --fov=27x18.2 --projection=0 --output=modified.pto source.pto

When I run the application, pano_modify prints: Setting field of view to 27 x 17.9986

I looked at the pano_modfiy source code (http://sourceforge.net/p/hugin/hugin/ci/default/tree/src/tools/pano_modify.cpp), and it appears that on line 217, the FOV parameters is being parsed using int, where as the internal value is using doubles. Is there a reason for this? Can I change to doubles and recompile?

http://sourceforge.net/p/hugin/hugin/ci/default/tree/src/tools/pano_modify.cpp line 217:
int hfov, vfov;
int n=sscanf(optarg, "%dx%d", &hfov, &vfov);

becomes:
double hfov, vfov;
int n=sscanf(optarg, "%dx%d", &hfov, &vfov);

Thanks for your help
George

Question information

Language:
English Edit question
Status:
Solved
For:
Hugin Edit question
Assignee:
No assignee Edit question
Solved by:
tmodes
Solved:
Last query:
Last reply:
Revision history for this message
Best tmodes (tmodes) said :
#1

This was an oversight and has been fixed in the repository.
It needs some more changes than you have written.

Revision history for this message
George (george-banfill) said :
#2

Thanks for fixing this for me tmodes.

How would I go about getting a built version of this so I can try out the change? Is there a nightly build server or anything that I could pull the most recent from. Building all the C++ assemblies for windows is somewhat intimidating for a c# developer like me.

Thanks
George

Revision history for this message
George (george-banfill) said :
#3

Thanks tmodes, that solved my question.