heatpumpMonitor

trunk24: typos in protocol.py (lines 110+111)

Asked by alphaomega

Hi Robert,

I have seen that you have corrected some typos ("servial" => "serial") in trunk 24, but there are still two typos left in protocol.py in line 110:
self._newStyleServialCommunication = newStyleServia

Here, you also need to remove a "v", so it correctly reads: self._newStyleSerialCommunication
And at the end of "newStyleServia", the "l" is missing.

A question re. line 111:
value16 = extr_speed_actual 29 fixedPoint 2 0lCommunication

Is there maybe also a typo between "2" and "0lCommunication"? I do not understand what the syntax here is and what "0lCommunication" could mean.

Thanks for clarification/ correction!
Kind regards, ao

Question information

Language:
English Edit question
Status:
Solved
For:
heatpumpMonitor Edit question
Assignee:
No assignee Edit question
Solved by:
alphaomega
Solved:
Last query:
Last reply:
Revision history for this message
Christian jambor (jambor) said : 		#1

this looks like a small problem....

root@server:~/DIR/heatpumpmonitor# python protocol.py
  File "protocol.py", line 111
    value16 = extr_speed_actual 29 fixedPoint 2 0lCommunication
                                 ^
SyntaxError: invalid syntax
root@server:~/DIR/heatpumpmonitor# bzr update
Tree is up to date at revision 24 of branch /root/DIR/heatpumpmonitor

Revision history for this message
Robert Penz (robert-penz-name) said : 		#2

oops ... hit the middle mouse button at the wrong time and didn't even realize it, I guess. I removed the text and uploaded an new version. sorry must have happened after I tried the new version and before I uploaded it.

Revision history for this message
alphaomega (alpha-omega) said : 		#3

Thanks, Robert, that solved the problem.