Goby

Issue using Acknowledgements

Asked by Mark Barger

I'm currently having an issue using acknowledgements in Goby 1.1.1 (seeing the same in 1.1.2).

The issue I'm seeing appears to be related to bug 787896. I'm sending a single message to a single receiver (modem_id == 2), and requesting acknowledgement. The ack flag is being reset to 0 though, because dest == 0 (BROADCAST_ID) when the check is performed in queue.cpp.

In the log, the "sending data to firmware from" message in queue_manager.cpp and the "popping from send stack" message in queue.cpp show dest == 0 as well.

The dest is ultimately getting set correctly though, because the CCCYC and CCTXD commands that are sent both have dest == 2.

I've been using version 1.1.1, but I just tried 1.1.2 and I'm seeing the same issue there. It's very possible that I'm configuring something incorrectly (which is why I'm posting this here, and not as a bug), but I'm out of ideas on what that might be. Also, if I comment out the check to override the ack flag in queue.cpp, then the acknowledgements seem to work fine. I'm not proposing that as a solution, but just did it as a sanity check.

Is there anything else I should try?

Question information

Language:
English Edit question
Status:
Solved
For:
Goby Edit question
Assignee:
No assignee Edit question
Solved by:
Mark Barger
Solved:
Last query:
Last reply:
Revision history for this message
toby schneider (tes) said : 		#1

Can you post the relevant code and XML files?

You need to make sure that both:

1. The MACManager slot has a destination of 2 or -1 (QUERY_DESTINATION_ID, aka autoselect)
2. The message itself has a destination of 2 (pulled from the <header><dest_id></dest_id></header> field of the message).

I suspect the second is lacking.

Thanks-
-t

Revision history for this message
Mark Barger (mark-barger) said : 		#2

Yep, I was missing the <dest_id><name>dest</name></dest_id> fragment from the message xml. Once I added that, I could see when I ran from iCommander (as opposed to my java MOOSBeans app) that I was also publishing the trigger variable without the info it needed (I had been leaving it blank). Once I changed these two pieces, it's working great.

Thanks!