I have written a patch with new features, what now?

Asked by Gerrit Addiks on 2012-08-14

Hello Maintainers,

I have written a patch for ginn 0.2.4 which adds two new features. First an keyword "moveMouse" to put into the modifiers which allows mouse-movement while the gesture and secondly two keywords "preventBegin" and "preventEnd" which allows to hold keys while performing a wish. Using both you can for example simulate a mouse-button holding down using three fingers for drag&drop/dragging windows/selecting text which is what i use it for.

This is the first time i have patched an open source program and i am sure i failed at some point, but what now? What i have done is get the source by "apt-get source ginn", changed that source and created a *.patch file from that. If anyone has interest in it i can mail it to someone. If not, well then i just keep use it for myself. I hope to not have upset somebody and if i did im sorry. This is just my first attempt to get myself into this open source thing. :)

Sincerely,

Gerrit Addiks

Question information

Language:
English Edit question
Status:
Answered
For:
ginn Edit question
Assignee:
No assignee Edit question
Last query:
2012-08-14
Last reply:
2012-08-14
Gerrit Addiks (addiks) said : #1

By the way, here is what your wishes.xml would look like using it (snippet from my file):

<ginn>
  <global>

...

    <wish gesture="Drag" fingers="3">
      <action name="drag begin" when="start">
        <trigger prop="delta x" min="-9999" max="9999"/>
        <button modifier1="preventEnd">1</button>
      </action>
    </wish>

    <wish gesture="Drag" fingers="3">
      <action name="drag mousemove" when="update">
        <trigger prop="delta x" min="-9999" max="9999"/>
        <button modifier1="moveMouse" modifier2="preventBegin" modifier3="preventEnd">1</button>
      </action>
    </wish>

    <wish gesture="Drag" fingers="3">
      <action name="drag end" when="finish">
        <trigger prop="delta x" min="-9999" max="9999"/>
        <button modifier1="preventBegin">1</button>
      </action>
    </wish>

...

  </global>

</ginn>

Stephen M. Webb (bregma) said : #2

Hi, and thanks for contributing to Ubuntu.

The best way to go about getting a change in to ginn is to open a bug against the package and then propose your change as a merge request against the upstream source.

See https://wiki.ubuntu.com/Bugs/HowToFix for some suggestions.

Be advised that the original maintainers of ginn are no longer actively developing it for future releases. You may end up having to fork it and maintain your won packages in a PPA on Launchpad. Using packages in a PPA makes it easier to share your work with others as wells as uninstall or upgrade from time to time.

Can you help with this problem?

Provide an answer of your own, or ask Gerrit Addiks for more information if necessary.

To post a message you must log in.