Comment 1 for bug 1264744

Revision history for this message
Karol Będkowski (karol-bedkowski) wrote : Re: exclude-globbing-filelist don't works

Hi,
I think this problem is result from reading twice filelist file.

For example:
~/tmp/test-> tree -a in
in
├── .config
│   └── test1-in-config.txt
├── test2.txt
└── test3.txt

~/tmp/test-> cat filelist.txt
- /home/k/tmp/test/in/.config

duplicity -vi --progress --no-encryption --exclude-globbing-filelist filelist.txt /home/k/tmp/test/in/ file:///home/k/tmp/test/out/
Using archive dir: /home/k/.cache/duplicity/b5e2f4b829db69341672537d1ced3377
Using backup name: b5e2f4b829db69341672537d1ced3377
[....]
Reading globbing filelist filelist.txt

[******** First reading file list]

Main action: inc
================================================================================
duplicity 0.6.23 (January 24, 2014)
Args: /usr/bin/duplicity -vi --progress --no-encryption --exclude-globbing-filelist filelist.txt /home/k/tmp/test/in/ file:///home/k/tmp/test/out/
Linux kntbk 3.13-1-686-pae #1 SMP Debian 3.13.5-1 (2014-03-04) i686
/usr/bin/python 2.7.6 (default, Feb 26 2014, 06:42:04)
[GCC 4.8.2]
================================================================================
Using temporary directory /tmp/duplicity-iljo9e-tempdir
Temp has 47721136128 available, backup will use approx 34078720.
Local and Remote metadata are synchronized, no sync needed.
Last full backup date: none
No signatures found, switching to full backup.
A .
A test2.txt
A test3.txt

[******** In this point file list is correct, below - second reading filelist ]

Reading globbing filelist filelist.txt
Using temporary directory /home/k/.cache/duplicity/b5e2f4b829db69341672537d1ced3377/duplicity-HXwYmn-tempdir
Using temporary directory /home/k/.cache/duplicity/b5e2f4b829db69341672537d1ced3377/duplicity-wbRfbF-tempdir
AsyncScheduler: instantiating at concurrency 0
A .
A .config
A .config/test1-in-config.txt
A test2.txt
A test3.txt

[******** in this point exclude list is empty]
[...]

IMHO - file with exclude list is simple not reopened.

Similar problem:
duplicity --progress --no-encryption --exclude-filelist filelist.txt /home/k/tmp/test/in/ file:///home/k/tmp/test/out/

Reading filelist filelist.txt
Sorting filelist filelist.txt
Local and Remote metadata are synchronized, no sync needed.
Last full backup date: Thu Mar 13 18:26:27 2014
Reading filelist filelist.txt
Traceback (most recent call last):
  File "/usr/bin/duplicity", line 1495, in <module>
    with_tempdir(main)
  File "/usr/bin/duplicity", line 1489, in with_tempdir
    fn()
  File "/usr/bin/duplicity", line 1338, in main
    do_backup(action)
  File "/usr/bin/duplicity", line 1471, in do_backup
    incremental_backup(sig_chain)
  File "/usr/bin/duplicity", line 623, in incremental_backup
    commandline.set_selection()
  File "/usr/lib/python2.7/dist-packages/duplicity/commandline.py", line 891, in set_selection
    sel.ParseArgs(select_opts, select_files)
  File "/usr/lib/python2.7/dist-packages/duplicity/selection.py", line 235, in ParseArgs
    filelists[filelists_index], 0, arg))
  File "/usr/lib/python2.7/dist-packages/duplicity/selection.py", line 313, in filelist_get_sf
    self.filelist_read(filelist_fp, inc_default, filelist_name)
  File "/usr/lib/python2.7/dist-packages/duplicity/selection.py", line 349, in filelist_read
    for line in filelist_fp.read().split(separator):
ValueError: I/O operation on closed file