DC++

download dir doesn't exist, so a download was deleted instead of moved from temporary dir

Asked by Bogdan Harjoc

DCPlusPlus-0.791, Windows 7

I typed the temp and complete download dirs in the settings, and mistyped a non-existing path (drive letter actually) for both dirs.

Initially downloads didn't start, but I fixed both dir names in the settings and used 'Force connect' to make the downloads start.

After a download finished, it wasn't moved to the 'finished downloads' dir (both temp and finished dirs were on drive C). It didn't exist in the temp dir anymore either, so I assume it was deleted.

It's not clear to me why the 'temp dir' setting change had effect, but the 'completed download dir' didn't.

Question information

Language:
English Edit question
Status:
Solved
For:
DC++ Edit question
Assignee:
No assignee Edit question
Solved by:
eMTee
Solved:
Last query:
Last reply:

This question was originally filed as bug #952531.

Revision history for this message
eMTee (realprogger) said : 		#1

Because the temporary target is set when a download is started/resumed while the final target is set in the queue item when you add a new item to the download queue.

Revision history for this message
eMTee (realprogger) said : 		#2

...and if the final target path is invalid then the downloaded file isn't deleted. If there are errors moving the finished file to the target path then an informative message appears in the system log which contains where you can find your file.

Revision history for this message
Bogdan Harjoc (harjoc-gmail) said : 		#3

Hm, I didn't look in the system log, thanks for pointing that out.

But I'm not sure what the benefit is in moving the file to another temporary dir (and one would have to know to check the system log). The dcpp temp dir is exactly for this: temporary downloads. My guess is most users, when a download finishes and the file doesn't show up in 'finished dir', look in 'temp dir'.

Wouldn't it be better to just let the user move the file manually if dcpp fails to move it to 'finished dir' ?

Revision history for this message
Best eMTee (realprogger) said : 		#4

This is what actually happening.

My previouis answer wasn't clear enough so read it as:

...and if the final target path is invalid then the downloaded file isn't deleted. If there are errors moving the finished file to the target path then the file is kept in the unfinished directory and an informative message appears in the system log which contains what happened and under what name you can find the file in the temporary folder.

See the possible error messages at the system log help ( http://dcplusplus.sourceforge.net/webhelp/window_system_log.html ) they start with "Unable to move..."

Revision history for this message
Bogdan Harjoc (harjoc-gmail) said : 		#5

I see. This behaviour would be ideal IMO.

I'll check again, but from what I remember the finished file was gone (not kept in tempdir, with a temp suffix).

Thanks again.

Revision history for this message
Bogdan Harjoc (harjoc-gmail) said : 		#6

Thanks eMTee, that solved my question.