Comment 33 for bug 1512323

On Mon, Nov 16, 2015 at 08:03:57AM -0000, Martin Pitt wrote:
> It's still in siphash, due to a similar problem with the out argument:

> 0x2a02a9e8 in siphash24_finalize (out=0x2a065229 "", state=0xbefff970) at src/basic/siphash24.c:182
> 182 *(le64_t*)out = htole64(state->v0 ^ state->v1 ^ state->v2 ^ state->v3);

> I'll follow up on the upstream PR.

That is a bug in siphash24, but the only place where an unaligned 'out'
argument is passed to siphash24_finalize() in practice is the test case, so
that's not urgent to fix.

But certainly, siphash24_finalize() needs to be fixed either by changing the
argument to uint64_t* or by handling unaligned buffers.