Comment 3 for bug 54624

Thanks Martin. I'm just starting to orient to the codebase, so certainly all pointers are appreciated.

If it's done in the commit builder, does this mean the "add" operation would succeed silently, and it would only warn during commit? From a user perspective, I think I'd want the warning at add time.

I'm also wondering exactly what action it takes when it finds the large file(s). Should it refuse to add it, and require a command line option to force (as in the original description above)? Or should it merely warn that you've added it? And is this only checked for binary files?

I think having a configurable size threshold makes sense, and perhaps setting it to 0 can turn it off.

Agreed on the test plan.

Shannon