Olive manipulates dirstate. Is this a bug?

Asked by Matthias Müller-Reineke on 2007-07-19

System: Ubuntu 6.06 with bzr and bzr-gtk 0.17

When you execute the following commands you can see that starting olive changes the file dirstate. I've investigated that with pdb. As far as I remember (it's a few days ago) it is caused by a call to changes_from in olive/__init__.py:_load_right.
I'm not so fammiliar with bzr's internals. Is this ...
* a bug?
* dangerous?
* harmless?

Commands for reproducing this behaviour:

mkdir dirstate_manipulation
cd dirstate_manipulation/
mkdir a.orig
cd a.orig/
bzr init
mkdir b
cd b
touch c
cd ..
bzr add
bzr commit -m blah
cd ..
cp -a a.orig a
cd a
olive-gtk
# It's sufficient to close olive immideately.
cd ..
diff -r *

Question information

Language:
English Edit question
Status:
Solved
For:
Bazaar GTK+ Frontends Edit question
Assignee:
No assignee Edit question
Solved by:
Jelmer Vernooij
Solved:
Last query:
Last reply:
Revision history for this message
Jelmer Vernooij (jelmer) said :
#1

dirstate is allowed to change when just doing reads; some of the data in it is used for caching

Revision history for this message
Best Jelmer Vernooij (jelmer) said :
#2

in other words, this is harmless. I think you'll see that 'bzr status' also modifies dirstate.

Revision history for this message
Matthias Müller-Reineke (matthias-mueller-reineke) said :
#3

Thanks Jelmer Vernooij, that solved my question.