[edit-patch] should not unapply quilt patches

Bug #947180 reported by Michael Hall
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
devscripts (Debian)
Fix Released
Unknown
devscripts (Ubuntu)
Fix Released
Undecided
Michael Hall

Bug Description

edit-patch will currently unapply all quilt patches before committing changes. However, when some of those patches are applied to the branch already, running edit-patch will unapply those as well, resulting in more changes in the commit than the developer is actually applying.

== IRC #ubuntu-devel ==
09:50 < mhall119> so the question is, when there are applied patches on the branch,
                  should they be unapplied in a separate revision from the actual
                  change, or as part of the same revision
09:50 < dholbach> :)
09:50 < mhall119> not so much "if" as "when"
09:50 < cjwatson> absolutely not in a separate revision
09:50 < mhall119> cjwatson: why?
09:50 < cjwatson> because each revision should be self-contained
09:51 < cjwatson> if there are applied patches on the branch, then you should leave
                  the branch that way
09:51 < cjwatson> if there are unapplied patches on the branch, then you should
                  leave the branch that way
09:51 < mhall119> cjwatson: ok, but edit-patch unapplies all patches
09:51 < cjwatson> edit-patch shouldn't be changing the branch handling policy
09:51 < mhall119> so should edit-patch not be used?
09:51 < cjwatson> surely it should be fixed
09:53 < mhall119> so that's a bug in edit-patch? If so, I'll file a bug report
09
:55 < cjwatson> sounds like it; it should try as hard as possible to leave stuff
                  the way it found it ...

Related branches

summary: - edit-patch should not unapply quilt patches
+ [edit-patch] should not unapply quilt patches
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in devscripts (Ubuntu):
status: New → Confirmed
Revision history for this message
Daniel Holbach (dholbach) wrote :

Small example:

  bzr branch ubuntu:geany
  cd geany
  edit-patch small-desktop-file-fix
  <edit, document and commit>

Check the diff of the last commit to find a huge diff although you probably just changed 1 or 2 lines.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Barry, Jelmer, Michael: sorry for dragging you into this discussion, but it'd be nice to have your input as well.

Michael Hall (mhall119)
Changed in devscripts (Ubuntu):
assignee: nobody → Michael Hall (mhall119)
status: Confirmed → In Progress
Revision history for this message
Michael Hall (mhall119) wrote :
Revision history for this message
Daniel Holbach (dholbach) wrote :

Benjamin: can this be rolled into a release? I feel there's a number of new contributors regularly tripping over this.

Changed in devscripts (Debian):
status: Unknown → Fix Committed
Changed in devscripts (Debian):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.8 KiB)

This bug was fixed in the package devscripts - 2.11.6ubuntu1

---------------
devscripts (2.11.6ubuntu1) precise; urgency=low

  * Merge from Debian unstable. Remaining changes:
    - Demote Recommends to Suggests:
      + libcrypt-ssleay-perl: only needed for a corner case (uscan on SSL
        download sites), wasn't installed by default in previous releases
        either, and seems quite dead upstream; universe only.
      + debian-keyring: not useful enough in Ubuntu; universe only.
      + equivs: too much of a hack to install by default; universe only.
      + libsoap-lite-perl: only needed for one less common command ("select")
        for bts, which isn't useful for Ubuntu itself, and pulls in a lot of
        other universe Perl libraries; universe only.
    - scripts/debchange.{pl,1}:
      + Adjust --security template for Ubuntu.
      + Add -U/--upstream flag that forces original "just increment
        the end" behaviour; Ubuntu is upstream for some pieces of software.
      + Add --distributor= and DEBCHANGE_DISTRIBUTOR to override lsb_release
        output.
      + Default to "precise" as distribution.
      + Add "ubuntu1" to version string for new versions, with tweaks for
        special cases.
      + Add -R/--rebuild flag for Ubuntu's no-change rebuilds.
      + Don't use the last distribution in debian/changelog when doing
        "dch -r" on Ubuntu. "Just because it was last uploaded to jaunty
        doesn't mean that's the right thing to do now."
    - Add test/debchange.pl, test/Makefile: debchange test suite.
    - Rename XS-Vcs-* to XS-Debian-Vcs-*.

devscripts (2.11.6) unstable; urgency=low

  [ James McCoy ]
  * mk-build-deps: Fix handling of debian/control files. (Closes: #665496)
  * uscan: Fix formatting in man page. Thanks to Samuel Bronson for the
    patch. (Closes: #665325)
  * debsign: Fix quoting in handling of --debs-dir.
    (Closes: #666048, LP: #966867)

  [ Benjamin Drung ]
  * cowpoke.1, deb-reversion.dbk, dscextract.1: Fix typos "occured",
    "transfered", and "addtional". Thanks to A. Costa for the patches.
    (Closes: #655681)
  * debcommit:
    + Subversion 1.7 has only one .svn folder per working copy.
      Thanks to Simon Olofsson for the patch. (Closes: #645106)
    + Support .hg in parent directories.
      Thanks to Simon Olofsson for the patch. (Closes: #652967)

  [ David Prévot ]
  * Typo and stylish fix for dscextract(1). (Closes: #630423)

devscripts (2.11.5) unstable; urgency=low

  [ Adam D. Barratt ]
  * deb-reversion:
    + Re-fix handling of multi-word hooks. (Closes: #660782).
      This was originally fixed in 2.9.14 but accidentally broken again in
      2.9.26.
    + Correctly handle cases where a changelog file was not found, possibly
      because of the use of symlinks. (Closes: #660788)

  [ Jakub Wilk ]
  * deb-reversion: Simplify option parsing, also allowing simpler quoting of
    arguments.

  [ James McCoy ]
  * dd-list: Fix correlation of given package name when it does not match the
    source package name. (Closes: #655854)
  * dcmd: Escape directory name so it doesn't interfere with sed command.
    (Closes: #649227)
  * debsnap: Check whether architect...

Read more...

Changed in devscripts (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.