[edit-patch] should not unapply quilt patches
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
devscripts (Debian) |
Fix Released
|
Unknown
|
|||
devscripts (Ubuntu) |
Fix Released
|
Undecided
|
Michael Hall |
Bug Description
edit-patch will currently unapply all quilt patches before committing changes. However, when some of those patches are applied to the branch already, running edit-patch will unapply those as well, resulting in more changes in the commit than the developer is actually applying.
== IRC #ubuntu-devel ==
09:50 < mhall119> so the question is, when there are applied patches on the branch,
09:50 < dholbach> :)
09:50 < mhall119> not so much "if" as "when"
09:50 < cjwatson> absolutely not in a separate revision
09:50 < mhall119> cjwatson: why?
09:50 < cjwatson> because each revision should be self-contained
09:51 < cjwatson> if there are applied patches on the branch, then you should leave
09:51 < cjwatson> if there are unapplied patches on the branch, then you should
09:51 < mhall119> cjwatson: ok, but edit-patch unapplies all patches
09:51 < cjwatson> edit-patch shouldn't be changing the branch handling policy
09:51 < mhall119> so should edit-patch not be used?
09:51 < cjwatson> surely it should be fixed
09:53 < mhall119> so that's a bug in edit-patch? If so, I'll file a bug report
09:55 < cjwatson> sounds like it; it should try as hard as possible to leave stuff
Related branches
- Michael Vogt (community): Approve
- devscripts developers: Pending requested
-
Diff: 21 lines (+4/-1)1 file modifiedscripts/edit-patch.sh (+4/-1)
summary: |
- edit-patch should not unapply quilt patches + [edit-patch] should not unapply quilt patches |
Changed in devscripts (Ubuntu): | |
assignee: | nobody → Michael Hall (mhall119) |
status: | Confirmed → In Progress |
Changed in devscripts (Debian): | |
status: | Unknown → Fix Committed |
Changed in devscripts (Debian): | |
status: | Fix Committed → Fix Released |
Status changed to 'Confirmed' because the bug affects multiple users.