can't renominate to a series after the series bugtask was deleted

Bug #904902 reported by Diogo Matsubara
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Ian Booth

Bug Description

Steps to reproduce:
1. Open a bug you have permission to nominate/target to a series (e.g. https://bugs.qastaging.launchpad.net/test-project-foobar/+bug/864462)
2. Target it to a series (e.g. trunk)
3. Delete the targeted series task
4. Try to target to the trunk series again.

What happens:

trunk series doesn't show in the list of available series

Related branches

Curtis Hovey (sinzui)
tags: added: bugs series
summary: - can't nominate to a series that was previously deleted
+ can't renominate to a series after the series bugtask was deleted
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 904902] [NEW] can't nominate to a series that was previously deleted

On Fri, Dec 16, 2011 at 8:14 AM, Diogo Matsubara
<email address hidden> wrote:
> Public bug reported:
>
> Steps to reproduce:
> 1. Open a bug you have permission to nominate/target to a series (e.g. https://bugs.qastaging.launchpad.net/test-project-foobar/+bug/864462)
> 2. Target it to a series (e.g. trunk)
> 3. Delete the targeted series task
> 4. Try to target to the trunk series again.
>
> What happens:
>
> trunk series doesn't show in the list of available series

Isn't this a feature?

Revision history for this message
Curtis Hovey (sinzui) wrote :

I think this is a pretty uncommon case. Does this work after the page is reloaded? I think it does. If this is just about in-page javascript, I think this issue is only worth 1 hour of effort to fix.

This is just a case where a driver can target to the series, think he is mistaken, delete the bugtask (and confirm he knows what he is doing), then realised he was right the first time.

Revision history for this message
Curtis Hovey (sinzui) wrote :

We do not want to show trunk in most cases.
Users should only be able to nominate if there is more than one current or supported series. There are already bugs about why it is wrong to target to trunk.

Revision history for this message
Ian Booth (wallyworld) wrote :

I *think* the root cause here is that when the bug is first nominated for a series, an entry is created in the BugNomination table. This entry is used to prevent the same series being nominated against again. When the bugtask is deleted, nothing is done to the previously created BugNomination entry, so LP doesn't realise there's no longer a nominate for that series.

I would be possible I expect to simply delete the relevant entry from the BugNomination table when a bugtask is deleted. There'd still be an audit trail due to the BugActivity records.

Ian Booth (wallyworld)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Ian Booth (wallyworld)
Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Ian,

I wonder if this bug relates to an existing issue, bug 253608. You indirectly fixed the "cannot reject an approved nomination" problem when you add bug deletion.

Revision history for this message
Ian Booth (wallyworld) wrote :

Yes, I do think bug 253608 and this one have the same root cause. If we had bug dependencies implemented, I'd link them. They are not strictly duplicates I don't think but I'll mark them as such and ensure both issues are resolved.

Revision history for this message
Ian Booth (wallyworld) wrote :

Even though bug 253608 and this one have a root cause based on a row being in the BugNomination table, the exact cause and also solutions are different and should be landed as different branches. So unmarking as duplicate.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Ian Booth (wallyworld)
tags: added: qa-ok
removed: qa-needstesting
Deryck Hodge (deryck)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: hardening
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.