Distorted profile pictures on People Page

The fixed width and height are also defined in CSS. Note that if we remove this, images that are too big might make the whole layout look bad.

If we go ahead with this, should I make the change in the osi package only or at the karl level too?

I agree with Carlos's analysis. We've had the discussion in the past (Chipp/Jonathan) and the desire was to have the "picture view" be a fixed layout, rather than fluid.

I don't know how we can keep a fixed-size picture view without fixed-size pictures.

--Paul

On Nov 23, 2011, at 9:07 PM, Carlos de la Guardia wrote:

> The fixed width and height are also defined in CSS. Note that if we
> remove this, images that are too big might make the whole layout look
> bad.
>
> If we go ahead with this, should I make the change in the osi package
> only or at the karl level too?
>
> ** Changed in: karl3
> Status: New => In Progress
>
> --
> You received this bug notification because you are subscribed to KARL3.
> https://bugs.launchpad.net/bugs/892357
>
> Title:
> Distorted profile pictures on People Page
>
> Status in KARL3:
> In Progress
>
> Bug description:
> Not a big deal, but it looks like images on for people listings are distorted, where as the profile seems to have a good version.
>
> See Laura Brahmn’s profile for an example:
>
> Profile: https://karl.soros.org/profiles/lbrahm/
>
> Search:
> https://karl.soros.org/people/osi/c1/r3/communications/picture_view.html
>
> (see screenshot)
>
> From Robert: Removing the fixed width and height attributes on the
> image in photo listing view looks like an easy way to handle it.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/892357/+subscriptions

We can fix the size of the image container, but not force the images to fill all of it. This still keeps things aligned, at the cost of having some empty space in the container. I personally think this is a reasonable trade off to make, and am leaning in this direction. What do you guys think?

I made local changes on branch1 so you guys can see what I mean.
https://karlstaging.gocept.com/branch1/osf/people/osi/c1/r3/communications/picture_view.html

I can commit these changes if there are no objections.

I like it.

Want to steal the bug, merge your changes, and call it a day?

--Paul

On Nov 27, 2011, at 6:02 PM, Robert Marianski wrote:

> We can fix the size of the image container, but not force the images to
> fill all of it. This still keeps things aligned, at the cost of having
> some empty space in the container. I personally think this is a
> reasonable trade off to make, and am leaning in this direction. What do
> you guys think?
>
> I made local changes on branch1 so you guys can see what I mean.
> https://karlstaging.gocept.com/branch1/osf/people/osi/c1/r3/communications/picture_view.html
>
> I can commit these changes if there are no objections.
>
> --
> You received this bug notification because you are subscribed to KARL3.
> https://bugs.launchpad.net/bugs/892357
>
> Title:
> Distorted profile pictures on People Page
>
> Status in KARL3:
> In Progress
>
> Bug description:
> Not a big deal, but it looks like images on for people listings are distorted, where as the profile seems to have a good version.
>
> See Laura Brahmn’s profile for an example:
>
> Profile: https://karl.soros.org/profiles/lbrahm/
>
> Search:
> https://karl.soros.org/people/osi/c1/r3/communications/picture_view.html
>
> (see screenshot)
>
> From Robert: Removing the fixed width and height attributes on the
> image in photo listing view looks like an easy way to handle it.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/892357/+subscriptions

Updates in karl package:
https://github.com/karlproject/karl/commit/ee275f0a95e722431ba9699e2b432b1c634f7fbd

And osi package:
https://github.com/karlhosting/osi/commit/16d109b5e5f9e5d2ca2bb36a2e0aeff79aaa2b1a

Jim, this was fixed on the master (trunk), I believe. So you should be able to test it and tag it with today's release.

fixed