neutron

Plugin gets loaded twice

Bug #834449 reported by Sumit Naiksatam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Salvatore Orlando
neutron diablo-rbp "Diablo ReleaseBranchPoint"
quantum (Ubuntu)
Fix Released
Undecided
Unassigned
Nominated for Precise by Yolanda Robla

Bug Description

I believe there was bug earlier which resolved something similar, but I am still seeing this in the latest build (plugin loads exactly twice):

2011-08-25 23:42:54 DEBUG [quantum.service] ********************************************************************************
2011-08-25 23:42:54 DEBUG [quantum.service] Configuration options gathered from config file:
2011-08-25 23:42:54 DEBUG [quantum.service] /root/sw/openstack/src/quantum/quantum/quantum/common/../../etc/quantum.conf
2011-08-25 23:42:54 DEBUG [quantum.service] ================================================
2011-08-25 23:42:54 DEBUG [quantum.service] / quantumversions
2011-08-25 23:42:54 DEBUG [quantum.service] /v1.0 quantumapi
2011-08-25 23:42:54 DEBUG [quantum.service] api_extensions_path extensions
2011-08-25 23:42:54 DEBUG [quantum.service] bind_host 0.0.0.0
2011-08-25 23:42:54 DEBUG [quantum.service] bind_port 9696
2011-08-25 23:42:54 DEBUG [quantum.service] debug True
2011-08-25 23:42:54 DEBUG [quantum.service] verbose True
2011-08-25 23:42:54 DEBUG [quantum.service] ********************************************************************************
2011-08-25 23:42:54 INFO [quantum.service] Using paste.deploy config at: /root/sw/openstack/src/quantum/quantum/quantum/common/../../etc/quantum.conf
2011-08-25 23:42:54 DEBUG [quantum.manager] Plugin location:quantum.plugins.SamplePlugin.FakePlugin
2011-08-25 23:42:55 DEBUG [quantum.manager] Successfully imported Quantum plug-in.All compatibility tests passed
2011-08-25 23:42:55 DEBUG [routes.middleware] Initialized with method overriding = True, and path info altering = True
2011-08-25 23:42:55 DEBUG [quantum.manager] Plugin location:quantum.plugins.SamplePlugin.FakePlugin
2011-08-25 23:42:55 DEBUG [quantum.manager] Successfully imported Quantum plug-in.All compatibility tests passed
2011-08-25 23:42:55 INFO [quantum.common.extensions] Initializing extension manager.
2011-08-25 23:42:55 INFO [quantum.common.extensions] Loading extension file: __init__.py
2011-08-25 23:42:55 DEBUG [quantum.common.extensions] Extended resource: extensions
2011-08-25 23:42:55 DEBUG [routes.middleware] Initialized with method overriding = True, and path info altering = True
2011-08-25 23:42:55 DEBUG [eventlet.wsgi.server] (8431) wsgi starting up on http://0.0.0.0:9696/

Related branches

lp:~salvatore-orlando/neutron/bug834449
dan wendlandt: Approve
Somik Behera: Approve (netstack-core)
Sumit Naiksatam: Approve
Diff: 119 lines (+9/-11)
8 files modified
etc/quantum.conf (+1/-1)
quantum/api/__init__.py (+2/-4)
quantum/common/extensions.py (+1/-1)
quantum/manager.py (+1/-1)
quantum/plugins/cisco/tests/unit/test_cisco_extension.py (+1/-1)
tests/unit/client_tools/stubs.py (+1/-1)
tests/unit/test_api.py (+1/-1)
tests/unit/test_cli.py (+1/-1)
Sumit Naiksatam (snaiksat)
Changed in quantum:
milestone: none → diablo-rbp
Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Thanks for reporting this bug.
This is definitely a regression. The root cause is the extension framework, as the following line:

        ext_mgr = PluginAwareExtensionManager(extensions_path,
                                              QuantumManager().get_plugin())

not only invokes the class method get_plugin but also creates an instance of QuantumManager, whose constructor load the plugin.
The fix is very trivial.

A branch has been attached and proposed for merge.

Changed in quantum:
importance: Undecided → High
assignee: nobody → Salvatore Orlando (salvatore-orlando)
status: New → In Progress
Revision history for this message
Sumit Naiksatam (snaiksat) wrote :

Thanks Salvatore. I have tested this and can confirm that the plugin is loaded only once after your fix. However, I did notice that the extensions are getting loaded now (might not necessarily be a side effect of your fix) even when the configured plugin is not supporting them. Just want to make sure that this is indeed the expected behavior.

I would have ideally expected the loading of a particular plugin to drive the loading of the extensions it supports (since without the support from the plugin, the loading of the extensions does not have too much meaning). If you agree with this line of reasoning, an enhancement bug can be created for the extension framework (I can create it).

Salvatore Orlando (salvatore-orlando)
Changed in quantum:
status: In Progress → Fix Committed
dan wendlandt (danwent)
Changed in quantum:
status: Fix Committed → Fix Released
Yolanda Robla (yolanda.robla)
Changed in quantum (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.