OpenLP

QString and QVariant auto-conversion

Bug #779201 reported by matysek on 2011-05-07

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenLP	Fix Released	Critical	Unassigned	OpenLP 2.1.1
	Packaging	Fix Released	High	matysek	OpenLP 2.1.1

Bug Description

Since PyQt 4.6 (PyQt uses different version scheme than Qt) support auto conversion of QString to/from python unicode type and auto conversion to/from QVariant type.

Practically, it means that it is not necessary use types QString and/or QVariant in python code.

Using auto-conversion could make the source code simpler.

For more info see

http://www.riverbankcomputing.co.uk/static/Docs/PyQt4/html/incompatible_apis.html
http://www.pyinstaller.org/wiki/PyQtChangeApiVersion

Related branches

lp:~googol-deactivatedaccount/openlp/bug-779201-2

Merged into lp:openlp at revision 2132

Raoul Snyman: Approve on 2012-12-28

Tim Bentley: Approve on 2012-12-28

Jonathan Corwin (community): Approve on 2012-12-28

Diff: 7208 lines (+1200/-1498)

92 files modified

openlp.pyw (+9/-0)
openlp/core/__init__.py (+7/-10)
openlp/core/lib/__init__.py (+76/-9)
openlp/core/lib/db.py (+11/-14)
openlp/core/lib/formattingtags.py (+3/-6)
openlp/core/lib/listwidgetwithdnd.py (+1/-1)
openlp/core/lib/mediamanageritem.py (+19/-22)
openlp/core/lib/plugin.py (+3/-6)
openlp/core/lib/searchedit.py (+3/-3)
openlp/core/lib/serviceitem.py (+4/-4)
openlp/core/lib/settings.py (+0/-68)
openlp/core/lib/settingsmanager.py (+8/-15)
openlp/core/lib/spelltextedit.py (+2/-3)
openlp/core/lib/toolbar.py (+1/-1)
openlp/core/lib/ui.py (+4/-4)
openlp/core/ui/aboutdialog.py (+4/-4)
openlp/core/ui/aboutform.py (+1/-1)
openlp/core/ui/advancedtab.py (+36/-52)
openlp/core/ui/exceptionform.py (+11/-12)
openlp/core/ui/firsttimeform.py (+21/-27)
openlp/core/ui/formattingtagform.py (+6/-6)
openlp/core/ui/generaltab.py (+42/-63)
openlp/core/ui/maindisplay.py (+11/-20)
openlp/core/ui/mainwindow.py (+81/-102)
openlp/core/ui/media/__init__.py (+6/-9)
openlp/core/ui/media/mediacontroller.py (+7/-8)
openlp/core/ui/media/phononplayer.py (+3/-5)
openlp/core/ui/media/playertab.py (+4/-5)
openlp/core/ui/media/vlcplayer.py (+5/-6)
openlp/core/ui/media/webkitplayer.py (+8/-10)
openlp/core/ui/pluginform.py (+8/-15)
openlp/core/ui/printserviceform.py (+14/-19)
openlp/core/ui/screen.py (+8/-15)
openlp/core/ui/servicemanager.py (+58/-63)
openlp/core/ui/shortcutlistform.py (+7/-10)
openlp/core/ui/slidecontroller.py (+20/-24)
openlp/core/ui/themeform.py (+55/-86)
openlp/core/ui/thememanager.py (+45/-54)
openlp/core/ui/themestab.py (+8/-12)
openlp/core/ui/wizard.py (+12/-12)
openlp/core/utils/__init__.py (+11/-12)
openlp/core/utils/actions.py (+8/-8)
openlp/core/utils/languagemanager.py (+12/-16)
openlp/plugins/alerts/alertsplugin.py (+4/-4)
openlp/plugins/alerts/forms/alertform.py (+17/-17)
openlp/plugins/alerts/lib/alertstab.py (+14/-20)
openlp/plugins/bibles/bibleplugin.py (+6/-9)
openlp/plugins/bibles/forms/bibleimportform.py (+42/-52)
openlp/plugins/bibles/forms/bibleupgradeform.py (+24/-26)
openlp/plugins/bibles/forms/booknameform.py (+1/-1)
openlp/plugins/bibles/forms/editbibleform.py (+11/-11)
openlp/plugins/bibles/lib/__init__.py (+7/-8)
openlp/plugins/bibles/lib/biblestab.py (+24/-38)
openlp/plugins/bibles/lib/csvbible.py (+4/-4)
openlp/plugins/bibles/lib/http.py (+6/-6)
openlp/plugins/bibles/lib/manager.py (+8/-11)
openlp/plugins/bibles/lib/mediaitem.py (+66/-76)
openlp/plugins/bibles/lib/opensong.py (+5/-5)
openlp/plugins/bibles/lib/osis.py (+3/-3)
openlp/plugins/custom/forms/editcustomform.py (+4/-4)
openlp/plugins/custom/lib/customtab.py (+3/-5)
openlp/plugins/custom/lib/mediaitem.py (+8/-12)
openlp/plugins/images/imageplugin.py (+2/-3)
openlp/plugins/images/lib/imagetab.py (+3/-5)
openlp/plugins/images/lib/mediaitem.py (+14/-17)
openlp/plugins/media/lib/mediaitem.py (+12/-14)
openlp/plugins/media/lib/mediatab.py (+8/-9)
openlp/plugins/media/mediaplugin.py (+4/-4)
openlp/plugins/presentations/lib/mediaitem.py (+14/-17)
openlp/plugins/presentations/lib/presentationcontroller.py (+3/-6)
openlp/plugins/presentations/lib/presentationtab.py (+9/-12)
openlp/plugins/remotes/lib/httpserver.py (+9/-15)
openlp/plugins/remotes/lib/remotetab.py (+11/-16)
openlp/plugins/songs/forms/editsongform.py (+44/-51)
openlp/plugins/songs/forms/editverseform.py (+4/-3)
openlp/plugins/songs/forms/mediafilesform.py (+1/-1)
openlp/plugins/songs/forms/songexportform.py (+8/-10)
openlp/plugins/songs/forms/songimportform.py (+8/-10)
openlp/plugins/songs/forms/songmaintenanceform.py (+22/-22)
openlp/plugins/songs/lib/__init__.py (+14/-13)
openlp/plugins/songs/lib/db.py (+7/-3)
openlp/plugins/songs/lib/ewimport.py (+2/-2)
openlp/plugins/songs/lib/mediaitem.py (+15/-23)
openlp/plugins/songs/lib/openlyricsexport.py (+2/-3)
openlp/plugins/songs/lib/powersongimport.py (+4/-4)
openlp/plugins/songs/lib/songimport.py (+1/-2)
openlp/plugins/songs/lib/songstab.py (+10/-16)
openlp/plugins/songs/lib/xml.py (+4/-4)
openlp/plugins/songs/lib/zionworximport.py (+11/-12)
openlp/plugins/songs/songsplugin.py (+6/-10)
openlp/plugins/songusage/forms/songusagedetailform.py (+15/-19)
openlp/plugins/songusage/songusageplugin.py (+13/-18)

lp:openlp

lp:~mzibricky/openlp/packaging

Merged into lp:openlp/packaging at revision 9

Tim Bentley: Approve on 2013-02-03

Raoul Snyman: Approve on 2013-02-03

lp:openlp/packaging

Tim Bentley (trb143) on 2011-05-08

Changed in openlp:
importance:	Undecided → Wishlist

Revision history for this message

Tim Bentley (trb143) wrote on 2011-07-04:

Had a quick look at this and all the LanguageManager code needs to be looked at as it is QT based.

The idea is good but will take some time to get working and not break things

Jonathan Corwin (j-corwin) on 2012-03-08

Changed in openlp:
status:	New → Confirmed

Andreas Preikschat (googol-deactivatedaccount) on 2012-05-17

Changed in openlp:
assignee:	nobody → Andreas Preikschat (googol)

Andreas Preikschat (googol-deactivatedaccount) on 2012-05-17

Changed in openlp:
status:	Confirmed → In Progress

Revision history for this message

matysek (mzibricky) wrote on 2012-05-18:

This is a type of change which has to be merged at once.

Also the Windows and Mac build scripts has to be updated.

Revision history for this message

Andreas Preikschat (googol-deactivatedaccount) wrote on 2012-05-19: Re: [Bug 779201] Re: QString and QVariant auto-conversion

> This is a type of change which has to be merged at once.
>
> Also the Windows and Mac build scripts has to be updated.
>
What exactly has to be changed with the build scripts?

Regards

Revision history for this message

matysek (mzibricky) wrote on 2012-05-19:

Build scripts should replace the runtime hook in pyinstaller directory with a custom one. As described in
http://www.pyinstaller.org/wiki/Recipe/PyQtChangeApiVersion

Andreas Preikschat (googol-deactivatedaccount) on 2012-10-03

Changed in openlp:
milestone:	none → 2.1.1

Tim Bentley (trb143) on 2012-12-04

Changed in openlp:
importance:	Wishlist → Critical

Andreas Preikschat (googol-deactivatedaccount) on 2012-12-05

Changed in openlp:
status:	In Progress → Won't Fix
status:	Won't Fix → Fix Committed

Revision history for this message

Andreas Preikschat (googol-deactivatedaccount) wrote on 2012-12-28:

The build script has to be changed.

NOTE: 2.0 still needs the old build script!

Changed in openlp:
status:	Fix Committed → Fix Released

Revision history for this message

Dmitriy Marmyshev (marmyshev) wrote on 2012-12-29:

latest OpenLP, OSX.

Steps:
1 Open settings
2. change something on general tab
3. save it and then:

Traceback (most recent call last):
File "openlp/core/ui/generaltab.py", line 277, in load
self.numberEdit.setText(settings.value(u'ccli number', u''))
TypeError: QLineEdit.setText(QString): argument 1 has unexpected type 'QPyNullVariant'

Revision history for this message

Tim Bentley (trb143) wrote on 2012-12-30:

Unable to reproduce on Linux. Are you running on OSX as the build scripts may need to be amended to support SIP

Revision history for this message

matysek (mzibricky) wrote on 2012-12-30:

I need to fix the osx build for that change.

Revision history for this message

matysek (mzibricky) wrote on 2013-01-02:

The QPyNullVariant is a real bug #1095268.

Andreas Preikschat (googol-deactivatedaccount) on 2013-02-05

Changed in openlp:
status:	Fix Released → Fix Committed

Andreas Preikschat (googol-deactivatedaccount) on 2013-02-06

no longer affects:	openlp/packaging
no longer affects:	openlp/packaging-2.0

Tim Bentley (trb143) on 2014-11-02

Changed in openlp:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.