[6.0] Cash and bank journals are unintendedly created as refund journals

Bug #741863 reported by Stefan Rijnhart (Opener)
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
Stefan Rijnhart (Opener)

Bug Description

In 6.0 head, the chart of accounts wizard creates bank and cash journals as refund journals. This is an unintended consequence of the fact that the same python dictionary is reused for journal creation, right after the creation of the refund journals. The 'refund_journal' boolean value is never overwritten or deleted.

We noticed this when manually encoding cash entries on accounts with default taxes messed up our tax report.

The same problem does not appear to exist in trunk anymore due to a rewrite of this part of the code.

Related branches

Revision history for this message
Azazahmed Saiyed (OpenERP) (saz-openerp) wrote :

Hello Stefan,

I have tested the issue in stable version but did not find any wrong behavior in journal type. I have attached the screen shot for your reference after running the wizard of installing the chart of account for belgium.

So please check it and notify us with more information if problem still persists at your end.

Thanks.

Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Azazahmed Saiyed (OpenERP) (saz-openerp) wrote :
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Azazahmed,

if you add the field 'refund_journal' to the tree view you will see what I mean.

Cheers,
Stefan.

Revision history for this message
xrg (xrg) wrote : Re: [Bug 741863] Re: [6.0] Cash and bank journals are unintendedly created as refund journals

On Wednesday 30 March 2011, you wrote:
> Hi Azazahmed,
>
> if you add the field 'refund_journal' to the tree view you will see what
> I mean.
>

Confirmed and solved the issue. Thanks Stephan.

BQI account.journal> table id, name, type, refund_journal from search_read([])
[2011-03-30 11:18:30] INFO:web-services:successful login from 'admin' using
database 'test_bqi'
id| name | type |refund_journal
------------------------------------------------------
13|Current |bank |False
14|Deposit |bank |False
15|Cash |cash |False
12|Purchase Refund Jour|purchase_refund|True
10|Purchase Journal |purchase |False
9 |Sales Journal |sale |False
11|Sales Refund Journal|sale_refund |True
5 |Bank Journal - (test|bank |False
6 |Checks Journal - (te|bank |False
7 |Cash Journal - (test|cash |False
4 |Expenses Credit Note|purchase_refund|True
3 |Expenses Journal - (|purchase |False
1 |Sales Journal - (tes|sale |False
2 |Sales Credit Note Jo|sale_refund |True

xrg (xrg)
Changed in openobject-addons:
status: Incomplete → Fix Committed
Changed in openobject-addons:
assignee: nobody → xrg (xrg)
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Thanks for the fix Stefan,

Your branch has been merged into stable by revision 4640 <email address hidden>.

Changed in openobject-addons:
status: Fix Committed → Fix Released
milestone: none → 6.0.3
importance: Undecided → Medium
importance: Medium → Low
assignee: xrg (xrg) → nobody
assignee: nobody → Stefan Rijnhart (Therp) (stefan-therp)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.