Big memory leak

Bug #66188 reported by Rui Matos
14
Affects Status Importance Assigned to Milestone
gnome-session (Ubuntu)
Fix Released
Medium
Ubuntu Desktop Bugs
Dapper
Invalid
Medium
Ubuntu Desktop Bugs

Bug Description

I've found a big memory leak in gnome-session. I think it might be on the ubuntu patch to the logout dialog but I haven't tested the package without that patch yet to be sure.

Steps to reproduce:

1. Open a terminal and run 'top' on it sorting the processes by memory usage ('M').

2. Set gnome-power-manager to aks what to do when the power button is pressed.

3. Press the power button.

4. The ubuntu logout dialog will appear.

5. Either hit the Escape key or the Cancel button to dismiss the dialog.

6. You'll see that the gnome-session process has grown ~4 Mb of RSS memory.

7. Repeat steps 3-6 until you are convinced this is a big memory leak :-)

Revision history for this message
Rui Matos (tiagomatos) wrote :

Forgot to specify the version:

gnome-session 2.16.1-0ubuntu1

This is an up-to-date Edgy.

Revision history for this message
Rui Matos (tiagomatos) wrote :

I deleted debian/patches/11_session_dialog.patch and rebuilt the package.

I tested with:

$ gnome-session-save --gui --kill

and the results with the upstream logout dialog are the same. i.e. there's a
memory leak somewhere and it's not on ubuntu's dialog. I'm sorry for pointing
the finger so hastily at it, I guess that my visceral dislike for it got in the
way and it really shouldn't have. Again, sorry, I'll try to be more objective.

Changed in gnome-session:
status: Unconfirmed → Confirmed
Revision history for this message
didier (did447-deactivatedaccount) wrote :

Still there (or it's a new one with the same effect) in 2.17.90 at least with Ubuntu patches.

It's not only with the Escape key or the Cancel button, but with all of them:

from /proc/id/smaps (no swap)

before switching user

31769000-3422f000 rw-p 31769000 00:00 0
Size: 43800 kB
Rss: 43800 kB
Shared_Clean: 0 kB
Shared_Dirty: 0 kB
Private_Clean: 8760 kB
Private_Dirty: 35040 kB

After

31769000-34509000 rw-p 31769000 00:00 0
Size: 46720 kB
Rss: 46720 kB
Shared_Clean: 0 kB
Shared_Dirty: 0 kB
Private_Clean: 8760 kB
Private_Dirty: 37960 kB

Note:
1) the patch is after debian/rules apply-patches
2) there's more leaks but they are small.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for the patch didier, that's fixed with that upload:

 gnome-session (2.17.90.1-0ubuntu2) feisty; urgency=low
 .
   * debian/patches/13_smoother_fading.patch:
     - updated with fix from "didier" to fix memory leak (Ubuntu: #66188)

Changed in gnome-session:
assignee: nobody → desktop-bugs
importance: Undecided → Medium
status: Confirmed → Fix Released
Revision history for this message
jmspeex (jean-marc-valin) wrote :

How about applying the fix to Dapper? Looks like bug #92143, which I filed.

Revision history for this message
Sebastien Bacher (seb128) wrote :

opening dapper task

Changed in gnome-session:
assignee: nobody → desktop-bugs
importance: Undecided → Medium
status: Unconfirmed → Confirmed
Revision history for this message
JC Hulce (soaringsky) wrote :

Thank you for reporting this bug. I am closing it as invalid, because it is fixed in later versions of Ubuntu and Dapper is EOL.

Changed in gnome-session (Ubuntu Dapper):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.