NM should notice changes to /etc/network/interfaces automatically

Bug #61089 reported by Mika Fischer
70
Affects Status Importance Assigned to Milestone
network-manager (Baltix)
Fix Released
High
Mantas Kriaučiūnas
network-manager (Ubuntu)
Fix Released
High
Unassigned

Bug Description

When I have NM running and configure a static connection via network-admin or directly via /etc/network/interfaces NM still tries to configure the interface until either it is restarted or "Disable Network" and then "Enable Network" is clicked on the NM applet.

NM should notice changes to /etc/network/interfaces automatically and react accordingly.

Changed in network-manager:
status: Unconfirmed → Confirmed
Revision history for this message
Alessandro Decina (alessandro.decina) wrote :

Please test and review this patch.
/etc/network/interfaces is monitored and the device list rebuilt whenever /e/n/i is changed. The currently active device is kept active unless it has been disabled.
It uses inotify directly and not libgnomevfs since network-manager doesn't depend on gnome.
The patch is meant to be applied after the patches in debian/patches/ (eg you can just drop it in debian/patches/18_monitor_eni.patch and rebuild the package).

Revision history for this message
BOURLAS (b-costas) wrote :

please give more info of how can i test this patch?
I am using ubuntu feisty hurd 3, how I should apply it?

Martin Pitt (pitti)
Changed in network-manager:
importance: Undecided → Low
status: Confirmed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Bumping severity, this affects a lot of people.

Changed in network-manager:
importance: Low → High
Revision history for this message
Andrew Ash (ash211) wrote :

BOURLAS: the basic idea of testing the patch is to download the source of networkmanager, apply the patch that Alessandro wrote, and then compile and install the now-patched version. It will be much easier to just wait for it to be patched into networkmanager upstream and then Ubuntu will include the change.

Alessandro: have you sent this patch upstream so they can weigh in on it?

Revision history for this message
Alessandro Decina (alessandro.decina) wrote :

NetworkManager is ongoing a fairly big refactory (see http://live.gnome.org/NetworkManagerToDo) and the piece of code that the patch touches is probably going to be changed a lot.
So this patch was specific to the NM version packaged in ubuntu (0.6.4-6ubuntu1) at that time and was not meant to be applied upstream.

Revision history for this message
Martin Pitt (pitti) wrote :

Alessandro, thanks for that patch. At UDS this was discussed quickly, and that's indeed the way to go. We will see how to port that patch to 0.7. We also need to have that patch not cause similar problems like bug #90267.

Revision history for this message
Mantas Kriaučiūnas (mantas) wrote :

I've applied this patch for network-manager feisty's (Baltix 2.7/Ubuntu 7.04) branch and it seems, that this patch helps to solve manual static IP configuration.
Packages are available at official Baltix GNU/Linux repository - http://ftp.akl.lt/Linux/Baltix/Baltix-Ubuntu-packages/feisty/network-manager/

Changed in network-manager:
assignee: nobody → mantas
importance: Undecided → High
status: New → In Progress
Revision history for this message
Alexander Sack (asac) wrote :

this patch was applied with upload of 0.6.5-0ubuntu1 to gutsy.

Thanks,

 - Alexander

Changed in network-manager:
status: In Progress → Fix Released
Przemek K. (azrael)
Changed in network-manager (Baltix):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.