Ubuntu
firefox package

Ubuntu download button renders inccorrectly in Firefox 3.7 (trunk)

Bug #588595 reported by Justin Lebar
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mozilla Firefox
Fix Released
Medium
Ubuntu Mozilla PPA Bugs
Fix Released
Medium
Unassigned
Ubuntu Website - OBSOLETE
Invalid
Undecided
Unassigned
firefox (Ubuntu)
Invalid
Medium
Unassigned

Bug Description

See attached screenshot, from http://www.ubuntu.com/desktop/get-ubuntu/download The text "Start Download \ Ubuntu Desktop Edition 32-bit" should be on top of the orange button.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100601 Minefield/3.7a5pre

See original description
Tags: ppa
Revision history for this message
In , Mozilla-bugs-micahscomputing (mozilla-bugs-micahscomputing) wrote :

I'm affected on Ubuntu as well, so this seems to be platform independent:
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a5pre) Gecko/20100601 Ubuntu/10.04 (lucid) Minefield/3.7a5pre

Revision history for this message
In , Henri Sivonen (hsivonen) wrote :

Created an attachment (id=448704)
Actual test case

The test case isn't really a test case for this bug. Attaching a test case.

The behavior (and the spec) here changed at bug 558302 in an effort to match WebKit and IE8 more closely. It appears that spec and parser change didn't quite capture all important aspects of WebKit and IE8 behavior.

Revision history for this message
In , Henri Sivonen (hsivonen) wrote :

Spec bug filed http://www.w3.org/Bugs/Public/show_bug.cgi?id=9829

Revision history for this message
Justin Lebar (jlebar) wrote :

See attached screenshot, from http://www.ubuntu.com/desktop/get-ubuntu/download The text "Start Download \ Ubuntu Desktop Edition 32-bit" should be on top of the orange button.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100601 Minefield/3.7a5pre

Revision history for this message
Justin Lebar (jlebar) wrote :
Revision history for this message
Micah Gersten (micahg) wrote :

This bug is an upstream one and it would be quite helpful if somebody experiencing it could send the bug the to the people writing the software. You can learn more about how to do this for various upstreams at https://wiki.ubuntu.com/Bugs/Upstream. Thanks in advance!

tags: added: ppa
affects: ubuntu → firefox (Ubuntu)
Changed in firefox (Ubuntu):
status: New → Confirmed
Revision history for this message
Justin Lebar (jlebar) wrote :

I'm a FF developer, and I'm not sure this is a FF bug.

FF 3.7 introduced a new HTML5-compliant parser, and I think it's rejecting the content inside the <button> tag.

Here's the raw source:

<p><button class="download" onClick="document.forms['start-download'].submit();">
    <h5>Start download</h5>
    <h5 class='download-started' style='display: none;'>Download started</h5>
    <h6>Ubuntu Desktop Edition <span id="bitcount">32</span>-bit</h6>
</button></p>

And here's the generated DOM (from selecting the content and clicking "show selection source"):

<p><button class="download" onclick="document.forms['start-download'].submit();">
</button></p><h5>Start download</h5>
<h5 class="download-started" style="display: none;">Download started</h5>
<h6>Ubuntu Desktop Edition <span id="bitcount">32</span>-bit</h6>
<p></p>

Revision history for this message
Justin Lebar (jlebar) wrote :

Hm...maybe this actually is valid HTML5 as written. If I'm reading the spec [1] correctly, <button> should be able to contain that content since it's non-interactive.

I'll ask around.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-button-element

Revision history for this message
Justin Lebar (jlebar) wrote :

Looks like you guys are off the hook. I filed as https://bugzilla.mozilla.org/show_bug.cgi?id=569528

Revision history for this message
Micah Gersten (micahg) wrote :

Thanks for reporting this. Please report any other issues you may find.

Changed in firefox (Ubuntu):
importance: Undecided → Medium
status: Confirmed → Triaged
Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: Unknown → In Progress
Revision history for this message
In , Phiw (phiw) wrote :

*** Bug 575244 has been marked as a duplicate of this bug. ***

Revision history for this message
Draycen DeCator (ddecator) wrote :

Moving report from the Ubuntu 'firefox' package to the Ubuntu Mozilla PPA Bugs project since this is related to a PPA and not the official version in the repos.

Changed in ubuntu-mozilla-ppa-bugs:
importance: Undecided → Medium
status: New → Triaged
Changed in firefox (Ubuntu):
status: Triaged → Invalid
Revision history for this message
In , Phiw (phiw) wrote :

*** Bug 593114 has been marked as a duplicate of this bug. ***

Revision history for this message
In , Justin-lebar+bug (justin-lebar+bug) wrote :

Henri, is this invalid HTML?

Revision history for this message
In , Henri Sivonen (hsivonen) wrote :

(In reply to comment #6)
> Henri, is this invalid HTML?

Not per the current draft, I believe.

It's clear that the parser needs changing. I'll get to it.

Revision history for this message
In , Henri Sivonen (hsivonen) wrote :

Created attachment 473095
Fix implementing spec revision 5158

This patch doesn't have a test case, because bug 559023 will add more than enough <button> test cases.

Bug Watch Updater (bug-watch-updater)
Changed in firefox:
importance: Unknown → Medium
Revision history for this message
In , Jonas-sicking (jonas-sicking) wrote :

Comment on attachment 473095
Fix implementing spec revision 5158

rs=me

Revision history for this message
In , Henri Sivonen (hsivonen) wrote :

http://hg.mozilla.org/mozilla-central/rev/41aaa362225b

Revision history for this message
In , Henri Sivonen (hsivonen) wrote :

Marking as in-testsuite?, since the test cases will land as part of bug 559023.

Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: In Progress → Fix Released
Revision history for this message
Micah Gersten (micahg) wrote :

This should be fixed in the Daily PPA now. Please report any other bugs you may find.

Changed in ubuntu-mozilla-ppa-bugs:
status: Triaged → Fix Released
Revision history for this message
In , Henri Sivonen (hsivonen) wrote :

Test landed as part of bug 559023.

Matthew Nuzum (newz)
Changed in ubuntu-website:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.