Launchpad itself

Unique violation when importing translations from a branch

Bug #571210 reported by Jeroen T. Vermeulen
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Curtis Hovey

Bug Description

We're getting some unique-constraint violations from branch imports. Looks like the branch approver uses template names that already exist (perhaps as disabled templates?)

OOPS-1577RSBR1, OOPS-1577RSBR2, OOPS-1577RSBR3, OOPS-1577RSBR4, OOPS-1577RSBR5

Modern oops: OOPS-91882635e8551f53a0bd423d85dadcd5

See original description

Related branches

lp:~sinzui/launchpad/reimport-inactive-templates
j.c.sackett (community): Approve
Diff: 168 lines (+85/-1)
6 files modified
lib/lp/translations/interfaces/potemplate.py (+14/-1)
lib/lp/translations/model/approver.py (+9/-0)
lib/lp/translations/model/potemplate.py (+19/-0)
lib/lp/translations/tests/test_potemplate.py (+14/-0)
lib/lp/translations/tests/test_translationbranchapprover.py (+12/-0)
lib/lp/translations/tests/test_translationbuildapprover.py (+17/-0)
Данило Шеган (danilo)
tags: added: code-integration
Данило Шеган (danilo)
Changed in rosetta:
status: New → Triaged
importance: Undecided → High
Robert Collins (lifeless)
Changed in launchpad:
importance: High → Critical
Revision history for this message
Robert Collins (lifeless) wrote :

Has this been improved as part of the new self-service work ?

William Grant (wgrant)
summary: - Unique violation in branch imports
+ Unique violation when importing translations from a branch
Curtis Hovey (sinzui)
description: updated
Revision history for this message
Curtis Hovey (sinzui) wrote :

I created OOPS-91882635e8551f53a0bd423d85dadcd5 while investigating question #211684.

The series has inactive templates https://translations.launchpad.net/openteacher/3.x/+templates
and translation syncing is not seeing the two new POTS. I requested a one-time import to see if a rescan would find the missing pots. Instead the log shows an oops because org.openteacher.dialogs.updates is inactive.
    IntegrityError: duplicate key value violates unique constraint "potemplate__productseries__name__key"
    DETAIL: Key (productseries, name)=(40409, org.openteacher.dialogs.updates) already exists

I don't think this issue directly relates to the two missing templates. I think the importer must ignore templates that match inactive ones.

Curtis Hovey (sinzui)
Changed in launchpad:
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r16223 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/16223>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Ian Booth (wallyworld)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.