MariaDB

Windows compile error in ma_loghandler.c

Bug #550974 reported by Georg Richter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MariaDB
Fix Released
Undecided
Unassigned

Bug Description

compilation of ma_loghandler.c fails in line 1398, since fd was declared after macro call LINT_INIT_STRUCT()

Suggested fix:
=== modified file 'storage/maria/ma_loghandler.c'
--- storage/maria/ma_loghandler.c 2010-03-10 10:32:14 +0000
+++ storage/maria/ma_loghandler.c 2010-03-29 14:45:27 +0000
@@ -1394,8 +1394,9 @@

   {
     LOGHANDLER_FILE_INFO info;
+ File fd;
     LINT_INIT_STRUCT(info);
- File fd= open_logfile_by_number_no_cache(file);
+ fd= open_logfile_by_number_no_cache(file);
     if ((fd < 0) ||
         (translog_read_file_header(&info, fd) | my_close(fd, MYF(MY_WME))))
     {

Revision history for this message
Oleksandr "Sanja" Byelkin (sanja-byelkin) wrote : Re: [Bug 550974] [NEW] Windows compile error in ma_loghandler.c

Hi!

29 марта 2010, в 18:51, Georg Richter написал(а):

> Public bug reported:
>
> compilation of ma_loghandler.c fails in line 1398, since fd was
> declared after macro call LINT_INIT_STRUCT()
>
> Suggested fix:
> === modified file 'storage/maria/ma_loghandler.c'
> --- storage/maria/ma_loghandler.c 2010-03-10 10:32:14 +0000
> +++ storage/maria/ma_loghandler.c 2010-03-29 14:45:27 +0000
> @@ -1394,8 +1394,9 @@
>
> {
> LOGHANDLER_FILE_INFO info;
> + File fd;
> LINT_INIT_STRUCT(info);
> - File fd= open_logfile_by_number_no_cache(file);
> + fd= open_logfile_by_number_no_cache(file);
> if ((fd < 0) ||
> (translog_read_file_header(&info, fd) | my_close(fd,
> MYF(MY_WME))))
> {
>

Thank you a lot, but I'd better move LINT_INIT_STRUCT(info); lower...

Revision history for this message
Bo Thorsen (bo.thorsen) wrote :

Sanja and I have fixed the two places where this was seen. And I fixed another windows compilation issue. lp:maria compiles for me on Windows Vista using Visual Studio 2008 now.

Changed in maria:
status: New → Fix Committed
Sergei Golubchik (sergii)
Changed in maria:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.