Launchpad itself

TranslationBranchApprover ignores previous state of an entry

Bug #446160 reported by Henning Eggers
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Henning Eggers
Launchpad itself 3.1.10

Bug Description

The TranslationBranchApprover which is used when importing translation templates from Bazaar branches assumes that the queue entries it handles are new entries. It sets all sucessfully processed entries to "approved", ignoring that they may not have been in the "Needs Review" state.

Instead, it should check if the previous state of the entry really is "Needs Review" and only approve those.

Related branches

lp:~henninge/launchpad/bug-446160
Jeroen T. Vermeulen (community): Approve (code)
Diff: 39 lines
2 files modified
lib/lp/translations/model/translationbranchapprover.py (+2/-1)
lib/lp/translations/tests/test_translationbranchapprover.py (+17/-0)
Revision history for this message
Henning Eggers (henninge) wrote :

Fixed in devel 9733.

Changed in rosetta:
status: In Progress → Fix Committed
Ursula Junque (ursinha)
tags: added: qa-needstesting
Henning Eggers (henninge)
tags: added: qa-ok
removed: qa-needstesting
Данило Шеган (danilo)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.