kde-ui's get_disk_choices looks at wrong choice list

List of differences from "duplicates":
- bug 41982: KeyError: 4 (vs. 5 here)
- bug 41984: KeyError: 0 (vs. 5 here)
- bug 41986: KeyError: 3 (vs. 5 here)
- bug 41961: KeyError: 0 (vs. 5 here)
- bug 41996: last call in line 1430 (vs line 754 in other reports)

Same traceback (with KeyError: 4) also mentioned in bug 41680 (but cannot call it duplicate).

The bug is that get_disk_choices in the KDE frontend looks at autopartition_buttongroup_texts instead of part_disk_buttongroup_texts. The fix is obvious, but I won't attempt it until I've set up a test environment.

ubiquity (0.99.71) dapper; urgency=low

  [ Colin Watson ]
  * Fix line splitting in parted_server bindings, particularly affecting
    partitions with whitespace in their names (closes: Malone #41768).
  * Drop duplicate encode("UTF-8") calls while preseeding passwd/* (closes:
    Malone #42097).
  * Set LC_COLLATE=C for debconffiltered subprocesses; some other collation
    orderings confuse partman into mounting partitions the wrong way round
    (closes: Malone #40395).
  * GTK frontend:
    - Disable back/forward buttons while waiting for debconffiltered
      subprocesses (closes: Malone #41948).
    - Improve widget packing on resize (thanks, Xavier Claessens; closes:
      Malone #40227).
  * Automatic update of included source packages: partman-auto
    45ubuntu11, silo-installer 1.03ubuntu3.

  [ Jonathan Riddell ]
  * KDE Frontend:
    - Set busy cursor and disable buttons between steps
    - Fix reboot
    - Fix get_disk_choice, Closes Malone #41865
    - Fix unicode problem in get_disk_choice, Closes Malone #41893
    - Disable new_size_frame
    - Make qtparted use python subprocess instead of KProcess
    - Fix scrolling on crash dialogue

  [ Stephan Hermann ]
  * KDE Frontend:
    - Fixed crash in kde-ui.py on amd64, closes Malone #41883

 -- Colin Watson <email address hidden> Tue, 2 May 2006 17:31:54 +0100

Same problem in Kubuntu 6.06 Flight 7 but with another Traceback:

Traceback (most recent call last):
  File "/usr/bin/ubiquity", line 112, in ?
    install(sys.argv[1])
  File "/usr/bin/ubiquity", line 52, in install
    ret = wizard.run()
  File "/usr/lib/python2.4/site-packages/ubiquity/frontend/kde-ui.py", line 305, in run
    self.process_step()
  File "/usr/lib/python2.4/site-packages/ubiquity/frontend/kde-ui.py", line 719, in process_step
    self.process_disk_selection()
  File "/usr/lib/python2.4/site-packages/ubiquity/frontend/kde-ui.py", line 771, in process_disk_selection
    if self.manual_choice is None or unicode(choice, "utf-8") == self.manual_choice:
TypeError: decoding Unicode is not supported

Jindrich: no, different traceback => different problem. That's bug 43125, which I fixed on Friday.

I keep getting messages from you for bug reports I haven't sent, but
that's OK.
But I do want to let you know that there are no problems with the Ubuntu
Dapper Flight 7 installation. Everything runs smooth.
Good work, Mr. Watson!
Thank all the Ubuntu team for me.
Best wishes.

On 5/22/06, Colin Watson <email address hidden> wrote:
>
> ** Bug 45978 has been marked a duplicate of this bug
>
> --
> kde-ui's get_disk_choices looks at wrong choice list
> https://launchpad.net/bugs/41865
>

Don: if your bug is marked duplicate, you are automatically subscribed
to it. You can click on the launchpad link at the bottom of the mail and
click unsubscribe on that page.

Thanks for the tip Dennis.
    Don

On 5/25/06, Dennis Kaarsemaker <email address hidden> wrote:
>
> Don: if your bug is marked duplicate, you are automatically subscribed
> to it. You can click on the launchpad link at the bottom of the mail and
> click unsubscribe on that page.
>
> --
> kde-ui's get_disk_choices looks at wrong choice list
> https://launchpad.net/bugs/41865
>

Very similar to Jindrich's error output, I get

Traceback (most recent call last):
  File "/usr/bin/ubiquity", line 130, in ?
    install(sys.argv[1])
  File "/usr/bin/ubiquity", line 55, in install
    ret = wizard.run()
  File "/usr/lib/python2.4/site-packages/ubiquity/frontend/kde-ui.py", line 327, in run
    self.process_step()
  File "/usr/lib/python2.4/site-packages/ubiquity/frontend/kde-ui.py", line 746, in process_step
    self.process_disk_selection()
  File "/usr/lib/python2.4/site-packages/ubiquity/frontend/kde-ui.py", line 795, in process_disk_selection
    choice = self.get_disk_choice()
  File "/usr/lib/python2.4/site-packages/ubiquity/frontend/kde-ui.py", line 1390, in get_disk_choice
    return unicode(self.part_disk_buttongroup_texts[id])
KeyError: -1