POTMsgSet merge: yet another unique violation

Bug #403992 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Jeroen T. Vermeulen

Bug Description

When running the message-sharing merge script on elisa, I still see a unique violation during the POTMsgSet merging stage: https://pastebin.canonical.com/20283/

A poignant detail is that the unique violation is on a diverged message. That should narrow the search down a little.

Changed in rosetta:
status: New → In Progress
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

The problem is that _saveByDiverging is called, and thinks it can succeed, in a case where diverging actually causes a clash.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

No, that's not the whole story. _saveByDiverging itself also checks for clashes, without referring to the dicts.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

It looks as if the sacrifice_flags call in _mergePOTMsgSets isn't doing its job. A sync right after message.potmsgset is set in _mergePOTMsgSets exposes the problem right there. Could still be that a clash isn't noticed.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Cherry-pickable quick fix landed in devel 9059, db-devel 8359

Changed in rosetta:
importance: High → Critical
Changed in rosetta:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Full fix in devel 9098

Changed in rosetta:
status: In Progress → Fix Committed
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.